Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace fate thread pool metrics #5147

Open
keith-turner opened this issue Dec 6, 2024 · 0 comments
Open

Replace fate thread pool metrics #5147

keith-turner opened this issue Dec 6, 2024 · 0 comments
Labels
enhancement This issue describes a new feature, improvement, or optimization.
Milestone
4.0.0

Comments

@keith-turner
Copy link
Contributor

Is your feature request related to a problem? Please describe.

The thread pool that fate uses to execute fate transactions is instrumented for metrics. However the way fate uses the pool is places long running task on the pool and never queues anything after that. This makes the metrics for the pool useless for understanding what is going on with fate.

Describe the solution you'd like

Remove the metrics instrumentation for the fate thread pool. Add a new gauge that counts idle or running fate threads using the technique from this comment
@keith-turner keith-turner added the enhancement This issue describes a new feature, improvement, or optimization. label Dec 6, 2024
@keith-turner keith-turner added this to the 4.0.0 milestone Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement This issue describes a new feature, improvement, or optimization.
Projects
None yet
Milestone
4.0.0
Development

No branches or pull requests
1 participant
@keith-turner