Halt TabletServer on minc failure and no TabletServer lock #5169
+13
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlmarion
commented
Dec 12, 2024
| } else { | ||
| throw e; | ||
| } | ||
| } | ||
|
|
||
| // log.debug(String.format("MinC %,d recs in | %,d recs out | %,d recs/sec | %6.3f secs | |
There was a problem hiding this comment.
Curious why these log messages are commented out.
cshannon
reviewed
Dec 13, 2024
| try { | ||
| ret = super.call(); | ||
| } catch (Exception e) { | ||
| if (tabletServer.getLock() == null || !tabletServer.getLock().verifyLockAtSource()) { |
There was a problem hiding this comment.
Is there a small race condition here with calling getLock() twice? I'm not sure if it's possible for the state to really change in this case between reads but I was wondering if it's better to do something like
var lock = tabletServer.getLock();
if (lock == null || !lock.verifyLockAtSource()) {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #5137