Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZooReaderWriter.mutateExisting returns null if the Mutator did not change the entry #5063

Open
ctubbsii opened this issue Nov 14, 2024 · 0 comments
Milestone

Comments

@ctubbsii
Copy link
Member

If the Mutator returns null, indicating that the mutator did not change anything, that null result skips setting anything on the ZK node. There are a few problems with this:

  1. The behavior of returning null is not well defined in the Mutator class (null means don't set anything? empty byte array means clobber the existing?)
  2. mutateExisting behavior is not well defined (should it return the current data if it is unchanged?)
  3. mutateExisting implementation returns the mutate result, whether or not the data was unchanged
@ctubbsii ctubbsii added this to the 2.1.4 milestone Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant