What is S rank?

[hugovk]

Describe the bug

When I add include_all_commits=true my badge goes from A++ to S+

Expected behavior

I don't know what I expected, but I've no idea what S+ means. S is way down the alphabet, is it much worse than A-F?

Screenshots / Live demo link (paste the github-readme-stats link as markdown image)

[![hugovk's GitHub stats](https://github-readme-stats.vercel.app/api?username=hugovk&count_private=true&show_icons=true&hide_title=true)](https://github.com/anuraghazra/github-readme-stats)

Add include_all_commits=true:

[![hugovk's GitHub stats](https://github-readme-stats.vercel.app/api?username=hugovk&count_private=true&show_icons=true&hide_title=true&include_all_commits=true)](https://github.com/anuraghazra/github-readme-stats)

Screenshot

[jopemachine]

I don't know what I expected, but I've no idea what S+ means. S is way down the alphabet, is it much worse than A-F?

I think S means much better than A or A++. (not much worse than A-F).

That means the rating has gone up because the total number of commit is much higher when you include all your commit (private commits).

[Metalhearf]

This maybe could interest you, about the S to F grading.
https://en.wikipedia.org/wiki/Academic_grading_in_Japan

[hugovk]

OK, thanks, good to know!

I wonder how widely know Japanese grading is. Perhaps it'd be better to shift the grades to begin with A and end with, say, C.

Or add some extra pluse to the existing to A, rather than S.

Thanks!

[anuraghazra]

Yeah I guess I'll change this. A lot of people recommend me not to use S because it's confusing.

I intentionally did this to curve the rankings toward A and A++ even for low active users.

[avelino]

This maybe could interest you, about the S to F grading.
https://en.wikipedia.org/wiki/Academic_grading_in_Japan

Could you put in the documentation README

[kaisugi]

To be honest, rank S is not so popular even in Japan.
I've lived in Japan for 20 years and never had such grading systems.

[anuraghazra]

I've lived in Japan for 20 years and never had such grading systems.

It's mostly used in fictional grading. highly used in modern PC games.

[landonepps]

I intentionally did this to curve the rankings toward A and A++ even for low active users.

Is it even possible to get a B+?
https://github-readme-stats.vercel.app/api?username=tranminhson100
Here's a user with nearly as little activity as possible, and they have an A+.

[kaisugi]

https://github.com/anuraghazra/github-readme-stats/blob/master/src/calculateRank.js#L28-L34

The number of commits or contributions is weighted only 1.65 times as the number of issues you've opened. This evaluation is somewhat mismatched.
Maybe we should open another issue to discuss better way of ranking.

[kaisugi]

related to #455

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[hugovk]

Stale bot, please keep open, awaiting changes: #330 (comment)

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[hugovk]

stalebot, still relevant, thanks!

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[hugovk]

stalebot, still relevant, thanks!

[anuraghazra]

Hi @hugovk I think your original question is being answered that S+ Rank is better than A++

And for the rank evaluation we are already discussing it in #455

Closing this for now as resolved. feel free to open another issue if you have any other questions.

[hugovk]

Oh, I thought you were going to change it:

Yeah I guess I'll change this. A lot of people recommend me not to use S because it's confusing.

I intentionally did this to curve the rankings toward A and A++ even for low active users.

If not, I'll probably remove the ranking from my README, thank you anyway for your work!

[ttytm]

S Tier is a common thing in terms of ranking. I like it 👍

[Cry199]

It would be cool after S++ to have a GOD mode

[peterviegas]

What does the letter C mean?

[qwerty541]

Hey @peterviegas

From the documentation:

Available ranks are S (top 1%), A+ (12.5%), A (25%), A- (37.5%), B+ (50%), B (62.5%), B- (75%), C+ (87.5%) and C (everyone). This ranking scheme is based on the Japanese academic grading system. The global percentile is calculated as a weighted sum of percentiles for each statistic (number of commits, pull requests, reviews, issues, stars, and followers), based on the cumulative distribution function of the exponential and the log-normal distributions. The implementation can be investigated at src/calculateRank.js. The circle around the rank shows 100 minus the global percentile.