Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

antlr4 lacks automatic module name, which is inconsistent to antlr4-runtime #4628

Open
Stewori opened this issue May 24, 2024 · 0 comments
Open

Comments

@Stewori
Copy link

Stewori commented May 24, 2024

The newest antlr4 jar file distributed on maven central, i.e. https://repo1.maven.org/maven2/org/antlr/antlr4/4.13.1/antlr4-4.13.1.jar, lacks an automatic module name in its manifest file. That is inconsistent to the behavior of antlr4-runtime, which does explicitly declare the line

Automatic-Module-Name: org.antlr.antlr4.runtime

in its MANIFEST.MF file.
I believe that artifacts of a common roof project should ideally obey a common module name structure. Therefore I recommend that a similar line, i.e.

Automatic-Module-Name: org.antlr.antlr4

should be declared in the MANIFEST.MF file of (future) distribution jar files of the https://repo1.maven.org/maven2/org/antlr/antlr4 maven artifact.

I am aware of #2946, which is related, but rather old and does not address specifically and explicitly the inconsistence pointed out here. I also acknowledge that this is a low priority issue and just a small consistency concern. Please feel free to track it simply as a reminder to adjust this bit for the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant