Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for GL_EXT_debug_printf #11

Open
rcmz opened this issue Oct 11, 2024 · 5 comments
Open

support for GL_EXT_debug_printf #11

rcmz opened this issue Oct 11, 2024 · 5 comments
Labels
bug Something isn't working glslang Concern glsl linting

Comments

@rcmz
Copy link

rcmz commented Oct 11, 2024

Best vscode glsl extension that I found !
Unfortunately it does not like the string literals used in GL_EXT_debug_printf
This is detected as an error but compiles fine debugPrintfEXT("global thread id %v3u\n", gl_GlobalInvocationID);

@antaalt
Copy link
Owner

antaalt commented Oct 13, 2024

Hello, what are your arguments given to glslang ? It seems some flags are missing for glslang to work correctly with Vulkan currently. From here, EShMsgVulkanRules & EShMsgSpvRules should be set for vulkan, that might be some of what's missing, but even with this fix, it does not work. I need to look more into it.

@antaalt
Copy link
Owner

antaalt commented Oct 14, 2024

In fact, looking into this again, it seems to be related to character escaping, remove \n, everything is fine on my side. I will look if I can fix the escaping that must be done twice or something similar.

@rcmz
Copy link
Author

rcmz commented Oct 15, 2024

Oh yes indeed it is only the \n that is causing issue.
Thanks for taking a look at this

@antaalt antaalt added bug Something isn't working glslang Concern glsl linting labels Oct 17, 2024
@antaalt
Copy link
Owner

antaalt commented Nov 28, 2024

Hello again, I looked into it again, and it is a bug with the C API of glslang which I am using with rust bindings. I have filed an PR there, that hopefully will get merged and that should fix the issue !

@rcmz
Copy link
Author

rcmz commented Nov 29, 2024

Thanks ! The rabbit hole goes deeper

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working glslang Concern glsl linting
Projects
None yet
Development

No branches or pull requests

2 participants