Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor cf update document #382

Merged
merged 4 commits into from
Nov 7, 2024
Merged

Refactor cf update document #382

merged 4 commits into from
Nov 7, 2024

Conversation

muratugureminoglu
Copy link
Contributor

What does it do?

Describe your PR here.

Why is it needed?

Describe the issue you are solving. It would be great if you reference issue here with brief description.

Related issue(s)/PR(s)

Let us know if this is related to any issue/pull request:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. If you don't have an issue, please create one.
  • Prefix your PR title with feat: , fix: , chore: , docs:, or refactor:.
  • The description should clearly illustrate what problems it solves.
  • Ensure that the commit messages follow our guidelines.
  • Resolve merge conflicts (if any).
  • Make sure that the current branch is upto date with the main branch.

@netlify Netlify
Copy link

netlify bot commented Oct 11, 2024 •
edited
Loading

✅ Deploy Preview for ant-media ready!

Name Link
🔨 Latest commit a74f7c2
🔍 Latest deploy log https://app.netlify.com/sites/ant-media/deploys/672cd10bffc7aa0008c989b1
😎 Deploy Preview https://deploy-preview-382--ant-media.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Mohit-3196
Mohit-3196 approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@Mohit-3196 Mohit-3196 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@Mohit-3196 Mohit-3196 merged commit 29a3812 into master Nov 7, 2024
4 checks passed
@Mohit-3196 Mohit-3196 mentioned this pull request Nov 7, 2024
Open
@yashtandon113 yashtandon113 deleted the refactor-cf-update-document branch November 7, 2024 20:37
@yashtandon113 yashtandon113 linked an issue Nov 7, 2024 that may be closed by this pull request
Refactor AWS CloudFormation cluster update #285
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mohit-3196 Mohit-3196 Mohit-3196 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor AWS CloudFormation cluster update
3 participants
@muratugureminoglu @Mohit-3196 @yashtandon113