Support symfony 7 #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wiktor6
force-pushed
the
support-symfony-7
branch
from
89c4d88 to
b283546
Compare
konradkozaczenko
approved these changes
Oct 1, 2024
olekans
approved these changes
Oct 1, 2024
src/Enum/EnvironmentEnum.php
Outdated
| use MabeEnum\EnumSerializableTrait; | ||
|
|
||
| class EnvironmentEnum extends Enum implements \Serializable | ||
| enum EnvironmentEnum: string implements \JsonSerializable |
There was a problem hiding this comment.
Is this interface JsonSerializable needed here? From what I see, it will work the same without it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AC