Support symfony 7 #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wiktor6
force-pushed
the
support-symfony-7
branch
from
dbb6178 to
e6c69bc
Compare
lukasz-falda
approved these changes
Oct 1, 2024
composer.json
Outdated
| "roave/security-advisories": "dev-latest", | ||
| "symfony/phpunit-bridge": "^6.2.7" | ||
| "symfony/phpunit-bridge": "^6.4|^7.0" |
There was a problem hiding this comment.
why 6|7? This is for develop, use newest possible
phpunit.xml.dist
Outdated
| @@ -1,23 +1,18 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | |||
| xsi:noNamespaceSchemaLocation="vendor/phpunit/phpunit/phpunit.xsd" | |||
| xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.5/phpunit.xsd" | |||
| backupGlobals="false" | ||
| colors="true" | ||
| convertDeprecationsToExceptions="false" | ||
| cacheDirectory=".phpunit.cache" |
There was a problem hiding this comment.
is this not default or something?
There was a problem hiding this comment.
According to the documentation there is no default param for this one https://docs.phpunit.de/en/11.3/configuration.html#the-cachedirectory-attribute.
bmulawa
approved these changes
Oct 1, 2024
Wiktor6
force-pushed
the
support-symfony-7
branch
from
02f1f47 to
8c2e504
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AC