Fix cancel action - empty orderId in details #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ropczan
commented
Apr 17, 2024
| { | ||
| $response = $this->orderRequestService->retrieve($model->orderId(), PaymentHelper::getConfigKey($model, $payment)); |
There was a problem hiding this comment.
Here the orderId from the model was used, but it does not always have to exist, PaymentHelper::getOrderId tries to take the orderId from firstModel in the first place
lukasz-falda
approved these changes
Apr 19, 2024
| $request->setModel($payment->getDetails()); | ||
|
|
||
| $action->execute($request); | ||
| } |
There was a problem hiding this comment.
I can't see test with empty orderId in details and firstModel - we expect exception then. It's also nice to test this behavior
konradkozaczenko
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.