Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context menu with Lightspeed is rendered when Lightspeed is disabled. #1493

Open
kristof-mattei opened this issue Aug 3, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@kristof-mattei
Copy link

Summary

Disabling Ansible Lightspeed does not remote the context menu entries.

Worse, it is shown everywhere, not just in Ansible playbooks.

Link to offending source code:

vscode-ansible/package.json

Lines 755 to 756 in a2c4e3f

"group": "2_main@1",
"command": "ansible.lightspeed.playbookExplanation"

I have "ansible.lightspeed.enabled": false, in my settings.json.

Meaning the context menu should not be rendered, whether I'm in a playbook or not.

Example:

image

Extension version

v24.8.3

VS Code version

1.92.0

Ansible Version

❮ ansible --version
ansible [core 2.16.7]
  config file = None
  configured module search path = ['/home/kristof/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /home/kristof/.pyenv/versions/3.12.3/envs/ansible/lib/python3.12/site-packages/ansible
  ansible collection location = /home/kristof/.ansible/collections:/usr/share/ansible/collections
  executable location = /home/kristof/.pyenv/versions/ansible/bin/ansible
  python version = 3.12.3 (main, Jul  1 2024, 11:24:56) [GCC 13.2.0] (/home/kristof/.pyenv/versions/3.12.3/envs/ansible/bin/python3.12)
  jinja version = 3.1.4
  libyaml = True

OS / Environment

Windows 11, WSL Ubuntu 22.04, ansible-lint 24.6.0

Relevant log output

No response

@alisonlhart
Copy link
Contributor

alisonlhart commented Oct 22, 2024

Adding this to our roadmap for research.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Roadmap
Development

No branches or pull requests

2 participants