Fix aws_cloudtrail even duplication bug #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hakbailey
force-pushed
the
aws_cloudtrail-plugin-bugfix
branch
from
b2ca4d1 to
a39268b
Compare
bzwei
approved these changes
Aug 30, 2023
ttuffin
pushed a commit
that referenced
this pull request
Dec 4, 2023
…ce (#169) Co-authored-by: Bill Wei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a minor bug in the aws_cloudtrail event_source plugin where cloudtrail events were retrieved and added to queue twice. The boto3 client
StartTimeparameter needs to be set to the last retrieved event time before the next batch of events is retrieved instead of after.