tests: switch to uv pip-compile for lockfiles #2084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 29, 2024
Merged
|
@gotmax23 Just checking but did you mark the other PRs to update dependencies as draft pending this one? |
|
No, they were marked as draft because they were generated using the broken version of pip-tools. I'll check them again so they can be merged in the interim (and also rebase this PR) later. Thanks! |
|
This is still on my radar. I've just been very busy. Thanks everyone for your feedback so far. |
gotmax23
force-pushed
the
uv-pip-compile
branch
from
2f626e5
to
bf7b367
Compare
This switches the nox pip-compile session and lockfiles to use uv pip compile (written in Rust and much faster) instead of pip-compile from pip-tools for our dependency update jobs. As a side effect, this addresses the issue brought up in ansible#1950 (comment), as we're no longer using pip-compile that can break anytime pip changes the private/internal APIs that pip-tools relies on. I re-generated the lockfiles with `--no-upgrade` to avoid extraneous changes in this PR. The only additions are the formatting of comments in the lockfile and colorama. colorama was added as a result of `uv pip-compile`'s `--universal` flag which creates "universal" lockfiles that include dependencies of other platforms, architectures, and Python versions than those of the system used to generate the lockfile. `--universal` should create more consistent results for contributors who use other systems (e.g., Mac OS or a newer Python version than the one used in CI). Fixes: ansible#1755
Suggested-by: Don Naro <[email protected]>
gotmax23
force-pushed
the
uv-pip-compile
branch
from
44ae1df
to
95cc63e
Compare
|
Ready for review |
webknjaz
approved these changes
Nov 25, 2024
Can you elaborate? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches the nox pip-compile session and lockfiles to use uv pip compile (written in Rust and much faster) instead of pip-compile from pip-tools for our dependency update jobs.
As a side effect, this addresses the issue brought up in #1950 (comment), as we're no longer using pip-compile that can break anytime pip changes the private/internal APIs that pip-tools relies on.
I re-generated the lockfiles with
--no-upgradeto avoid extraneous changes in this PR.The only additions are the formatting of comments in the lockfile and colorama.
colorama was added as a result of
uv pip-compile's--universalflag which creates "universal" lockfiles that include dependencies of other platforms, architectures, and Python versions than those of the system used to generate the lockfile.--universalshould create more consistent results for contributors who use other systems(e.g., Mac OS or a newer Python version than the one used in CI).
Fixes: #1755