-
Notifications
You must be signed in to change notification settings - Fork 948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate ShieldingTransfer in IBC VP #3431
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3431 +/- ##
==========================================
- Coverage 53.92% 53.87% -0.06%
==========================================
Files 317 317
Lines 107575 107670 +95
==========================================
- Hits 58011 58005 -6
- Misses 49564 49665 +101 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a comment. btw, run_ledger_ibc_with_hermes
is failing.
} else { | ||
let packet_data = serde_json::from_slice::<NftPacketData>( | ||
&packet.data, | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we're always falling back to nft transfers in case the port id is not for ics fungible token transfers. in case we receive a bogus port id, we strill try to validate the packet as an nft transfer. should we instead go case by case? even if here there are only 2 cases (transfer and nft transfer)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Putting a placeholder to prevent this pr from being merged while we understand and discuss some things offline
Thank you, Marco. The validation in this PR was duplicated and we need to check the MASP |
Describe your changes
ShieldingTransfer
is set by IBC relayer(Hermes). IBC VP has to validate it for the IBC message.Indicate on which release or other PRs this topic is based on
v0.39.0
Checklist before merging to
draft