Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add E2E Tests for MASP Wallet #305

Closed
Tracked by #2020
, #2532
...
murisi opened this issue Aug 9, 2022 · 2 comments · Fixed by #3365
Closed
Tracked by #2020
, #2532
...

Add E2E Tests for MASP Wallet #305

murisi opened this issue Aug 9, 2022 · 2 comments · Fixed by #3365
Assignees
@tzemanovic
Labels
enhancement New feature or request good first issue Good for newcomers MASP pre-mainnet Must happen before mainnet. testing wallet
Milestone
Phase 1: mainnet ...

Comments

@murisi
Copy link
Contributor

murisi commented Aug 9, 2022 •
edited
Loading

Make E2E tests for MASP wallet functionality to prevent future regressions. It should essentially test all subcommands of anomaw masp. I.e. under various CLI parameters, it should test the correct functioning of:

  • namadaw masp gen-addr ...
  • namadaw masp add ...
  • namadaw masp gen-key ...
  • namadaw masp list-keys ...
  • namadaw masp list-addrs ...
  • namadaw masp find ...

See transparent wallet E2E tests at tests/src/e2e/wallet_tests.rs for guidance on how to do this.
@murisi murisi added enhancement New feature or request wallet MASP namada labels Aug 9, 2022
@murisi murisi added testing good first issue Good for newcomers labels Aug 9, 2022
@cwgoes cwgoes mentioned this issue Oct 20, 2023
Closed
20 tasks
@karbyshev
Copy link
Contributor

The wallet CLI structure has been changed #2135

@cwgoes cwgoes added the pre-mainnet Must happen before mainnet. label Feb 5, 2024
@cwgoes cwgoes mentioned this issue Feb 6, 2024
Closed
6 tasks
@cwgoes cwgoes assigned karbyshev and unassigned murisi Feb 12, 2024
phy-chain pushed a commit to phy-chain/namada that referenced this issue Mar 1, 2024
@mateuszjasiuk
feat: async masp params loading (anoma#305)
eb16888
@brentstone
Copy link
Collaborator

@murisi @batconjurer @grarco @Fraccaman how relevant is this issue still?

@cwgoes cwgoes mentioned this issue Jun 4, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tzemanovic tzemanovic

Labels
enhancement New feature or request good first issue Good for newcomers MASP pre-mainnet Must happen before mainnet. testing wallet
Projects
No open projects
Namada-Old
Status: WIP
Milestone
Phase 1: mainnet genesis
Development

Successfully merging a pull request may close this issue.

masp e2e test anoma/namada
6 participants
@tzemanovic @karbyshev @murisi @cwgoes @brentstone @Scar26