wallet store decoding error is misleading

[tzemanovic]

When the format of the wallet.toml is incorrect, running commands that load the wallet fail with a misleading error (e.g. No pre-genesis wallet found at ...) instead reporting decoding error

[Kofituo]

Hello. I'm working on this issue. I'd like more information about it. How can I reproduce this error?
I see the error is related to this method:

namada/apps/src/lib/client/utils.rs

Lines 936 to 943 in 50caebb

	pub fn load_pre_genesis_wallet_or_exit(
	base_dir: &Path,
	) -> (Wallet<CliWalletUtils>, PathBuf) {
	try_load_pre_genesis_wallet(base_dir).unwrap_or_else(|| {
	eprintln!("No pre-genesis wallet found.",);
	safe_exit(1)
	})
	}

[tzemanovic]

hi @Kofituo ! It looks like the behavior has slightly changed in more recent versions. You can reproduce it by manually editing a wallet file ({base_dir}/pre-genesis/wallet.toml}) to contains some invalid contents. Using a wallet command (e.g. namadaw --pre-genesis list) doesn't seem to print anything on latest release v0.29. For a chain wallet (e.g. {base_dir}/{chain_id}/wallet.toml}) the command panics on unwrap of None

[Kofituo]

@tzemanovic thanks for the feedback. I'll give it a try. Could you kindly take a look at the linked pr as well?

[tzemanovic]

@Kofituo the PR lgtm!

[cwgoes]

@tzemanovic Is this still applicable? Should we merge the linked PR on the fork here?

[tzemanovic]

@tzemanovic Is this still applicable? Should we merge the linked PR on the fork here?

yeah, will do