Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to configure CometBFT genesis consensus params #2026

Closed
Tracked by #2004 ...
tzemanovic opened this issue Oct 23, 2023 · 2 comments
Closed
Tracked by #2004 ...

allow to configure CometBFT genesis consensus params #2026

tzemanovic opened this issue Oct 23, 2023 · 2 comments
Labels
ledger pre-mainnet Must happen before mainnet.

Comments

@tzemanovic
Copy link
Member

Allow to configure the cometBFT genesis consensus params from our genesis config, i.e.:

pub struct Params {
    /// Block size parameters
    pub block: Option<block::Size>,

    /// Evidence parameters
    pub evidence: Option<evidence::Params>,

    /// Validator parameters
    pub validator: Option<ValidatorParams>,

    /// Version parameters
    pub version: Option<VersionParams>,
}

We don't need the evidence params as outdated evidence is being handled in the ledger.

Depends on #711

@adrianbrink
Copy link
Member

Needs to be coordinated with #2122

@cwgoes cwgoes added the pre-mainnet Must happen before mainnet. label Feb 5, 2024
@sug0
Copy link
Contributor

sug0 commented Mar 4, 2024

the only thing we cared about from this issue was the ability to configure cometbft block sizes, which was implemented here: #2187

@sug0 sug0 closed this as completed Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ledger pre-mainnet Must happen before mainnet.
Projects
None yet
Development

No branches or pull requests

4 participants