Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBC: Denom validation is too strict #1453

Closed
yito88 opened this issue May 23, 2023 · 1 comment
Closed

IBC: Denom validation is too strict #1453

yito88 opened this issue May 23, 2023 · 1 comment
Assignees
@yito88

Comments

@yito88
Copy link
Member

yito88 commented May 23, 2023

IBC VP doesn't have to check an IBC message for the validation of the denom insertion.
And, it checks the insertion redundantly.

namada/shared/src/ledger/ibc/vp/denom.rs

Line 39 in d68081a

pub(super) fn validate_denom(&self, tx_data: &[u8]) -> Result<()> {

@yito88 yito88 self-assigned this May 23, 2023
@yito88
Copy link
Member Author

yito88 commented Aug 29, 2023

It was fixed in #1693.

namada/shared/src/ledger/ibc/vp/mod.rs

Line 170 in 1612bf1

fn validate_denom(&self, keys_changed: &BTreeSet<Key>) -> VpResult<()> {

@yito88 yito88 closed this as completed Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yito88 yito88

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yito88