From 5bce1b7b629bed6d1ea4e03ded573c87814d5461 Mon Sep 17 00:00:00 2001 From: "Justin R. Evans" Date: Fri, 21 Jul 2023 10:03:03 -0400 Subject: [PATCH] Remove unused address from messages --- .../src/Approvals/ApproveTx/ConfirmTx.tsx | 4 ++-- .../src/background/approvals/messages.ts | 18 ++---------------- 2 files changed, 4 insertions(+), 18 deletions(-) diff --git a/apps/extension/src/Approvals/ApproveTx/ConfirmTx.tsx b/apps/extension/src/Approvals/ApproveTx/ConfirmTx.tsx index 8fdcc74e66..1fd4aa37bf 100644 --- a/apps/extension/src/Approvals/ApproveTx/ConfirmTx.tsx +++ b/apps/extension/src/Approvals/ApproveTx/ConfirmTx.tsx @@ -50,7 +50,7 @@ export const ConfirmTx: React.FC = ({ address, msgId, txType }) => { case TxType.bond: { await requester.sendMessage( Ports.Background, - new SubmitApprovedBondMsg(msgId, address, password) + new SubmitApprovedBondMsg(msgId, password) ); setStatusInfo(""); setStatus(Status.Completed); @@ -91,7 +91,7 @@ export const ConfirmTx: React.FC = ({ address, msgId, txType }) => { case TxType.unbond: { await requester.sendMessage( Ports.Background, - new SubmitApprovedUnbondMsg(msgId, address, password) + new SubmitApprovedUnbondMsg(msgId, password) ); setStatusInfo(""); setStatus(Status.Completed); diff --git a/apps/extension/src/background/approvals/messages.ts b/apps/extension/src/background/approvals/messages.ts index 54fd2abddc..0f7e359a5c 100644 --- a/apps/extension/src/background/approvals/messages.ts +++ b/apps/extension/src/background/approvals/messages.ts @@ -69,11 +69,7 @@ export class SubmitApprovedBondMsg extends Message { return MessageType.SubmitApprovedBond; } - constructor( - public readonly msgId: string, - public readonly address: string, - public readonly password: string - ) { + constructor(public readonly msgId: string, public readonly password: string) { super(); } @@ -81,9 +77,6 @@ export class SubmitApprovedBondMsg extends Message { if (!this.msgId) { throw new Error("msgId must not be empty!"); } - if (!this.address) { - throw new Error("address must not be empty!"); - } if (!this.password) { throw new Error("Password is required to submit bond tx!"); } @@ -105,11 +98,7 @@ export class SubmitApprovedUnbondMsg extends Message { return MessageType.SubmitApprovedUnbond; } - constructor( - public readonly msgId: string, - public readonly address: string, - public readonly password: string - ) { + constructor(public readonly msgId: string, public readonly password: string) { super(); } @@ -117,9 +106,6 @@ export class SubmitApprovedUnbondMsg extends Message { if (!this.msgId) { throw new Error("msgId must not be empty!"); } - if (!this.address) { - throw new Error("address must not be empty!"); - } if (!this.password) { throw new Error("Password is required to submit unbond tx!"); }