Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

async shell #714

Open
tzemanovic opened this issue Dec 16, 2021 · 0 comments
Open

async shell #714

tzemanovic opened this issue Dec 16, 2021 · 0 comments
Labels
enhancement New feature or request ledger

Comments

@tzemanovic
Copy link
Member

tzemanovic commented Dec 16, 2021

We should come up with a strategy of what needs to be changed to take advantage of async to process ABCI requests.

I think we could:

  • In tower-abci split consensus requests (which need to be applied and respond in the same order) from all other requests
  • Split out consensus service as a sync loop over consensus requests preserving the order (i.e. what the shell does for all the requests atm)
    • The WASM execution in consensus service can have direct sync (read-only) access to the DB
    • Block are written to the DB
  • Provide async API for the DB (this could potentially use secondary instance in read-only mode https://github.com/facebook/rocksdb/wiki/Secondary-instance)
  • Implement async service for all the other connections
    • dry-run tx's are sent via Info queries, they can be executed via tokio::spawn_blocking and have either direct access to a read-only secondary instance or via messages to a worker (wasmer currently doesn't support yielding from WASM (Yielding from host calls wasmerio/wasmer#1127, when it does, we could make more of this async)
    • storage read queries call the async DB API

┆Issue is synchronized with this Asana task by Unito

@tzemanovic tzemanovic added enhancement New feature or request ledger labels Dec 16, 2021
@sync-by-unito sync-by-unito bot closed this as completed Feb 3, 2022
@juped juped reopened this Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ledger
Projects
No open projects
Status: Todo
Development

No branches or pull requests

2 participants