Skip to content
This repository has been archived by the owner on Jan 26, 2021. It is now read-only.

UI: Add toggling effect on buttons #1141

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

decon-harsh
Copy link
Member

Added toggling effect on buttons(nav tabs) in administrator/settings.html

Fixes #1134

Type of Change:

  • Code
  • User Interface

Mocks

Screenshot from 2020-09-30 01-11-22
Screenshot from 2020-09-30 01-11-25

How Has This Been Tested?

Manually

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials

Code/Quality Assurance Only

  • My changes generate no new warnings

@decon-harsh
Copy link
Member Author

Thanks @keshakaneria for the help , Please have a look!

@decon-harsh
Copy link
Member Author

Looks like I forgot to remove a console.log statement lol which i used to debug. Hope this isn't a big deal or should I remove it?

@codecov
Copy link

codecov bot commented Sep 29, 2020

Codecov Report

❗ No coverage uploaded for pull request base (develop@b58bc98). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1141   +/-   ##
==========================================
  Coverage           ?   87.08%           
==========================================
  Files              ?       85           
  Lines              ?     4057           
  Branches           ?      237           
==========================================
  Hits               ?     3533           
  Misses             ?      453           
  Partials           ?       71           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b58bc98...0c4db04. Read the comment docs.

@keshakaneria
Copy link
Member

Looks like I forgot to remove a console.log statement lol which i used to debug. Hope this isn't a big deal or should I remove it?

I guess let us keep the code clean. So you will have to remove it :) Also, do squash it so that, it is ready to merge ⚡

@decon-harsh
Copy link
Member Author

Looks like I forgot to remove a console.log statement lol which i used to debug. Hope this isn't a big deal or should I remove it?

I guess let us keep the code clean. So you will have to remove it :) Also, do squash it so that, it is ready to merge ⚡

I will. One more thing I saw an issue in backend-repo where the one who completed or took part in OSH has to write a blog about it . But i guess it is specifically for that repo . Can we do the same for vms? 😯

@keshakaneria
Copy link
Member

Looks like I forgot to remove a console.log statement lol which i used to debug. Hope this isn't a big deal or should I remove it?

I guess let us keep the code clean. So you will have to remove it :) Also, do squash it so that, it is ready to merge ⚡

I will. One more thing I saw an issue in backend-repo where the one who completed or took part in OSH has to write a blog about it . But i guess it is specifically for that repo . Can we do the same for vms? 😯

Yeah sure you can. Let me know the topic of your blog if you have one otherwise I will provide you one. Can you just link that issue of blog which you saw here?

@decon-harsh
Copy link
Member Author

anitab-org/mentorship-backend#904

My blog will focus mainly about the early problems i faced during my first PR and the increase in my confidence after the first PR . I would love to mention how easy it is to take part in OSH when the maintainers are ready to help you giving their best. etc Something sort of this😄.

@keshakaneria
Copy link
Member

My blog will focus mainly about the early problems i faced during my first PR and the increase in my confidence after the first PR . I would love to mention how easy it is to take part in OSH when the maintainers are ready to help you giving their best. etc Something sort of this😄.

Here it is. Go for it.

Copy link

@sanchibansal340 sanchibansal340 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@decon-harsh
Copy link
Member Author

@keshakaneria @sanchibansal340 This hasn't been reviewed yet!

Copy link
Member

@keshakaneria keshakaneria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sorry, I might have missed this issue for review. It looks good now. We are ready to go with this 🥳

@keshakaneria keshakaneria added the Status: Needs Review PR needs an additional review or a maintainer's review. label Jan 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Status: Needs Review PR needs an additional review or a maintainer's review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add toggling effect on buttons
3 participants