Skip to content
This repository has been archived by the owner on Jan 26, 2021. It is now read-only.

Bug: Modified create_organization function #1079

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

decon-harsh
Copy link
Member

@decon-harsh decon-harsh commented Sep 2, 2020

Modified create_organization function to handle Integrity Error which happens when user enters unlisted non unique organization.

Fixes #1042

Type of Change:

  • Code

Mocks

Screenshot of Error

Screenshot from 2020-09-02 02-49-56

After the changes

Volunteer account gets created!

Registration with Unlisted Organisation "New Organization"

Issue_1042

"New Organization" Exist in database

Screenshot from 2020-09-05 11-42-25

Registration with Listed Organisation (not approved)

Issue_1042(2)

Login

Screenshot from 2020-09-05 11-59-44

Screenshot from 2020-09-05 11-59-21

Code/Quality Assurance Only

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manually tested

Instructions to reproduce

  • Go to volunteer signup
  • Manually enter a non unique organisation

Checklist:

Delete irrelevant options.

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials

Code/Quality Assurance Only

  • My changes generate no new warnings

Copy link

@Kajol-Kumari Kajol-Kumari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codewise LGTM! @decon-harsh please do the following changes:
1.update the issue description with a GIF showing the fix
2. Fix the flake8 error. you can take reference from here to here.

@decon-harsh
Copy link
Member Author

Codewise LGTM! @decon-harsh please do the following changes:
1.update the issue description with a GIF showing the fix
2. Fix the flake8 error. you can take reference from here to here.

On it!

@decon-harsh
Copy link
Member Author

Will add a gif

@decon-harsh
Copy link
Member Author

decon-harsh commented Sep 5, 2020

Added necessary gif and pics.

Would like to show a new error.While Signing up as a volunteer , the city , country and state field has neither dropdowns nor their value gets saved the last screenshot clearly states the blank fields.

I have opened one issue regarding the dropdown but it has not been yet reviewed. If you say I will love to work on both these issues.

@Kajol-Kumari

Ps: Sorry I am bad with giving names to databases and enteries :)

Kajol-Kumari
Kajol-Kumari previously approved these changes Sep 5, 2020
Copy link

@Kajol-Kumari Kajol-Kumari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codewise LGTM 👍
@decon-harsh please squash the commits.

@decon-harsh
Copy link
Member Author

Check this @Kajol-Kumari

Copy link

@Kajol-Kumari Kajol-Kumari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@satya7289
Copy link
Contributor

Would like to show a new error.While Signing up as a volunteer , the city , country and state field has neither dropdowns nor their value gets saved the last screenshot clearly states the blank fields.

I have opened one issue regarding the dropdown but it has not been yet reviewed. If you say I will love to work on both these issues.

Regarding this, Have you migrate the cities light?

@satya7289
Copy link
Contributor

I guess yes , because it's working for admin but not for volunteer

In the last pic , it's evident there is a drop down when you try to edit those. But in the start there is not .

I will make migrations once again and will check.

Yes, Please check and confirm here. Thanks

@decon-harsh
Copy link
Member Author

@satya7289 the issue got solved , when i recreated the database and again made migrations!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Features for volunteer not visible for users having organisation other than the listed ones
3 participants