Skip to content
This repository has been archived by the owner on Jan 26, 2021. It is now read-only.

[Enhancement] Use 'black' and 'fake8' as pre-commit hook #1035

Open
3 tasks
Kajol-Kumari opened this issue Aug 25, 2020 · 6 comments · May be fixed by #1058
Open
3 tasks

[Enhancement] Use 'black' and 'fake8' as pre-commit hook #1035

Kajol-Kumari opened this issue Aug 25, 2020 · 6 comments · May be fixed by #1058
Assignees
Labels
Category: Quality Assurance Changes to code or files that improve testing or fixes bugs. Open Source Hack

Comments

@Kajol-Kumari
Copy link

Description

Currently we don't have any code formatting tool for ensuring that code is well formatted and organised.

Acceptance Criteria

Update [Required]

  • Add black and flake8 as pre-commit hook.

This will ensure that code is well formatted and organised.

Definition of Done

  • All of the required items are completed.
  • Approval by 1 mentor.

Estimation

4 hours

@Kajol-Kumari Kajol-Kumari added Category: Quality Assurance Changes to code or files that improve testing or fixes bugs. Open Source Hack labels Aug 25, 2020
@BALaka-18
Copy link

Hi @Kajol-Kumari, I would like to work on this issue. I am participating in OSH, kindly assign it to me when contribution period starts.

@SanketDG
Copy link

Great idea, we can also add a black github action that checks this in CI, incase someone did not install the pre-commit hook.

@Kajol-Kumari
Copy link
Author

Kajol-Kumari commented Aug 29, 2020

Hey @BALaka-18! Please accept my apologies but according to the new guidelines we received, we will count First come first serve on the basis of comments/claims done 1st september onwards. So, everyone who are interested in this issue, do come again on 1st and comment first to get assigned.

@BALaka-18
Copy link

Hi @Kajol-Kumari , I would like to work on this issue.

@Kajol-Kumari
Copy link
Author

Hey @BALaka-18 please go ahead with this issue.
Happy Learning :)

@BALaka-18
Copy link

@Kajol-Kumari I have made a PR (#1058). Kindly review it once.
Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Category: Quality Assurance Changes to code or files that improve testing or fixes bugs. Open Source Hack
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants