Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Google OAuth register and login to OSP #30

Open
1 of 4 tasks
bismitaguha opened this issue Jul 17, 2020 · 21 comments · May be fixed by #112
Open
1 of 4 tasks

Add Google OAuth register and login to OSP #30

bismitaguha opened this issue Jul 17, 2020 · 21 comments · May be fixed by #112
Assignees
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Type: Enhancement New feature or request.

Comments

@bismitaguha
Copy link
Contributor

bismitaguha commented Jul 17, 2020

Description

As a developer,
I need to implement Google sign on,
so that I can allow Google users to login using their Google account.

For being able to use the application, the user has to create a new account and confirm the email just to login. It's a long process. So by having Google OAuth we can make the process shorter for users who have a Google account.

Acceptance Criteria

Update [Required]

  • Implement Google OAuth login and registration
  • Write unit tests for the updates ^^

Definition of Done

  • All of the required items are completed.
  • Approval by 1 mentor.

Estimation

8 hours

@bismitaguha bismitaguha added Category: Coding Changes to code base or refactored code that doesn't fix a bug. Status: Available Issue was approved and available to claim or abandoned for over 3 days. Type: Enhancement New feature or request. labels Jul 17, 2020
@saideepesh000
Copy link

@bismitaguha, are we going to update the front-end of the app simultaneously, or else after completing this in the backend, we add this to the front-end?

@bismitaguha
Copy link
Contributor Author

@bismitaguha, are we going to update the front-end of the app simultaneously, or else after completing this in the backend, we add this to the front-end?

Yes the issue needs to be addressed in the frontend too, can be picked up by anybody!

@chinmaym07
Copy link
Member

Hey can I work on this issue .?

@Aaishpra
Copy link
Member

@isabelcosta @vj-codes I would like to work here.

@vj-codes
Copy link
Member

@chinmaym07 hey are you still interested to work on this issue ? If there's no response, it will be assigned to the contributor who claimed it next

@chinmaym07
Copy link
Member

chinmaym07 commented Jan 19, 2021

@chinmaym07 hey are you still interested to work on this issue ? If there's no response, it will be assigned to the contributor who claimed it next

If it's available ,Yes I am interested to work on it ... @vj-codes

@isabelcosta isabelcosta removed the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Jan 24, 2021
@isabelcosta
Copy link
Member

@chinmaym07 its assigned to you! Happy coding!

@isabelcosta
Copy link
Member

How's your issue work going @chinmaym07 ? Do you need any help or support?

@chinmaym07
Copy link
Member

Yes I am working on this issue. But I am facing this issue.
After login ,I am regularly keep getting this error whenever I try to update the details of the user , it shows me this error.
Screenshot from 2021-01-27 12-41-47

Can you @isabelcosta please help me with that.

@chinmaym07
Copy link
Member

chinmaym07 commented Jan 27, 2021

@isabelcosta I have got the file that contains this info .
https://anitab-org.zulipchat.com/#narrow/stream/237907-open-source-progs/topic/Questions/near/224148645
Thanks to sankalp.! 😁
But still the above error is coming

@isabelcosta
Copy link
Member

Did you manage to get help on Zulip? @chinmaym07

@chinmaym07
Copy link
Member

chinmaym07 commented Feb 1, 2021

Yes @isabelcosta .I have implemented google authentication . Only Github one is left ..which I am working on .
I think above error is solved by anitab-org/anitab-forms-web#51.

@isabelcosta
Copy link
Member

@chinmaym07 do you wish to deliver in one PR the Google OAuth, and on another issue the GitHub OAuth? I am okay with that, and I would even recommend it. Unless you already started that work and it creates more struggle for you

@chinmaym07
Copy link
Member

chinmaym07 commented Feb 9, 2021

Yes ..!! @isabelcosta

@codesankalp
Copy link
Member

@chinmaym07 Any updates on this?
You can make a PR of Google OAuth if Github one is still remaining.

@isabelcosta
Copy link
Member

yap, @chinmaym07 it is actually better if you just do one of the OAuth, and someone else can do it on another PR :) So that the PR is focused on one specific "little" task. Can you please choose one OAuth service, so we can update the issue.

@isabelcosta
Copy link
Member

isabelcosta commented Feb 24, 2021

I will update this to be about Google OAuth, and leave the GitHub to another.
@codesankalp could you please create an issue for implementing GitHub OAuth?
I can create real quick, nevermind

@isabelcosta isabelcosta changed the title Add OAuth register and login to OSP Add Google OAuth register and login to OSP Feb 24, 2021
@chinmaym07
Copy link
Member

@codesankalp , @isabelcosta sorry for taking so long to implement this . As my exams are going on. I will submit the pr asap. I have implemented the google one just testing it using the frontend. It's working using the frontend .
@codesankalp I think this issue only needs the Google auth api endpoint to be created in order to call it using the frontend. please correct me if there is any additional thing .

@isabelcosta
Copy link
Member

No problem @chinmaym07 I understand a lot of contributors in the community now are going through exams. You can update us from time to time. slow progress is still progress ;)
I think reducing the scope for google login was the right option here :)

@chinmaym07
Copy link
Member

chinmaym07 commented Mar 5, 2021

Update : Completed the backend implementation & tested using the frontend .
@codesankalp @isabelcosta Can I also open the frontend issue for this ?
Will make the PR by today 😀

@codesankalp
Copy link
Member

Great @chinmaym07 🎉
You can open the frontend issue for this.
Looking forward to seeing your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Type: Enhancement New feature or request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants