Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No bootstrap directory - differs from video #16

Open
greenonline opened this issue Jun 30, 2022 · 0 comments
Open

No bootstrap directory - differs from video #16

greenonline opened this issue Jun 30, 2022 · 0 comments

Comments

@greenonline
Copy link

greenonline commented Jun 30, 2022

I was following your video: Bootstrapping the Raspberry Pi automagically using GitHub Actions and bootstrap modules, hoping to make a PiHole appliance.

I created a repository from the template... however, there was no bootstrap directory. Instead there is .github/workflows, assets, modules, and the pimod directories.

I was unsure how to continue, so I gave up.

Why is the bootstrap directory missing, but is present in the video? Has the process changed?

I see that there is a bootstrap.Pifile... that the flowchart state should be used instead. However, this seems different (in format) from the two/three files that were in the bootstrap directory in the video: 00 - packages, 01-run.sh and 02-run.sh.

So, the questions are:

  • How does the format of the bootstrap.Pfile correlate to the three files?
  • Does the on_chroot section go before or after the INCLUDE modules/... lines, or does it not matter?
  • Shouldn't the video be removed as it is confusing, or updated to reflect that the bootstrap process has changed significantly? The process may be quite simple once you have got your head around it... however, at first glance, the process is very different from that demonstrated in the video and I would guess many people would just give up at this point - unless they are very determined and have the time to experiment. I am surprised that an issue hasn't already been raised. Please note that I am not ranting, just merely pointing out that it may put people off from using what would appear to be some rather useful software - if only it was easier to get it to work (with better instructions). After all, as is mentioned in the video, this is meant to be easy and enable novice users to adopt.

Upon further reading, it became clearer that it would be better to create modules/pi-hole.Pifile and place the code (curl... etc.) in there and then add a call to that file in bootstrap.Pifile like so:

INCLUDE modules/pi-hole.Pifile

Then after carefully reading modules/docker.Pifile, it became apparent that on_chroot is now changed to the PIMOD command RUN.

Also, later in the video (around 9:41), the environment variables used for the secrets are different.

So, in summary, assuming that I am correct (I haven't yet tested this), the video differs majorly from the actual process in the following four ways:

  • Use the bootstrap.Pifile, not bootstrap/02-run.sh
  • Create a module file, i.e. module/pi-hole.Pifile instead of using bootstrap/02-run.sh
  • Use RUN not on_chroot
  • In addition, the environment variables differ

It took me about three hours (actually more) to get my head around this... and arguably, had I not seen the video I would not have been confused by the red herrings, and I may have grasped the concept quicker... However, I must admit that the video is very useful in demonstating the use of github actions and the use of the template.

It is just a shame that the changes - w.r.t. the bootstrap/ directory, the switch from on_chroottoRUN switch, and the environment variable name changes - are not documented anywhere. Listing these changes in the YouTube video description would be a good place (as well as under the video link in the github page).

FWIW, I am attempting to document the process here, Using pi-bootstrap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant