Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frequency space filter test is likely broken #74

Open
angus-g opened this issue Mar 17, 2021 · 0 comments
Open

Frequency space filter test is likely broken #74

angus-g opened this issue Mar 17, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@angus-g
Copy link
Owner

angus-g commented Mar 17, 2021

For consistency with the analysis module, we should probably use da.fft in the FrequencySpaceFilter. We've already learned that fftfreq expects a sample spacing (rather than frequency), so the fs argument in test_frequency_filter is wrong. We should also be careful about angular vs. linear frequencies (there's probably a factor of 2*pi missing in the test/filter).

@angus-g angus-g added the bug Something isn't working label Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant