You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For consistency with the analysis module, we should probably use da.fft in the FrequencySpaceFilter. We've already learned that fftfreq expects a sample spacing (rather than frequency), so the fs argument in test_frequency_filter is wrong. We should also be careful about angular vs. linear frequencies (there's probably a factor of 2*pi missing in the test/filter).
The text was updated successfully, but these errors were encountered:
For consistency with the analysis module, we should probably use
da.fft
in theFrequencySpaceFilter
. We've already learned thatfftfreq
expects a sample spacing (rather than frequency), so thefs
argument intest_frequency_filter
is wrong. We should also be careful about angular vs. linear frequencies (there's probably a factor of 2*pi missing in the test/filter).The text was updated successfully, but these errors were encountered: