Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API inconsistent between file- and array-backed caches #66

Open
angus-g opened this issue Aug 31, 2020 · 0 comments
Open

API inconsistent between file- and array-backed caches #66

angus-g opened this issue Aug 31, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@angus-g
Copy link
Owner

angus-g commented Aug 31, 2020

With 013b53d ("Factor out advection cache class"), the intention was to be able to swap LagrangeParticleArray directly in for the file-backed cache. However, because the API is different between these classes, it doesn't quite work:

AttributeError: 'LagrangeParticleArray' object has no attribute 'set_group'
@angus-g angus-g added the bug Something isn't working label Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@angus-g