Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sampled velocities are incorrect on a spherical grid #65

Open
angus-g opened this issue Aug 4, 2020 · 1 comment
Open

Sampled velocities are incorrect on a spherical grid #65

angus-g opened this issue Aug 4, 2020 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@angus-g
Copy link
Owner

angus-g commented Aug 4, 2020

With a spherical grid (mesh="spherical"), Parcels expects lat/lon grid coordinates. Since velocities are usually given in m/s, they are converted to degree/s for consistency with the grid for advection. However, when we sample velocities for filtering, we expect them to be interpolated in their native units. Instead, we'll receive U and V in degree/s, and be some factor of 10e-6 out (this would also happen for Kh_zonal and Kh_meridional, if they were ever to be filtered: https://github.com/OceanParcels/parcels/blob/adc57b3edf65efd54793e5b97ee7d060102cd39d/parcels/tools/converters.py#L207-L209)

If we're using a spherical mesh, we should do one of:

  1. not convert units at sample time (most correct)
  2. convert back to "source" units after sampling (maybe easiest?)
  3. sample as usual, but convert back after advection, before filtering (least dependent on parcels)
@angus-g angus-g added the bug Something isn't working label Aug 4, 2020
@angus-g angus-g self-assigned this Aug 4, 2020
@angus-g
Copy link
Owner Author

angus-g commented Aug 4, 2020

With the merging of OceanParcels/Parcels#898, it looks like the second approach is the way to go. We should know soon how much of a difference it makes to perform filtering on spherical velocities compared to linear velocities (the former with a conversion after filtering, the latter with the conversion before filtering).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant