Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite minimum window filtering with bottleneck? #62

Open
angus-g opened this issue Jun 9, 2020 · 1 comment
Open

Rewrite minimum window filtering with bottleneck? #62

angus-g opened this issue Jun 9, 2020 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@angus-g
Copy link
Owner

angus-g commented Jun 9, 2020

xarray has ffill and bfill for filling NaNs by propagating values forward/backward (with an optional limit on the length of the propagation). This is almost exactly what we need to do for the minimum window functionality (where we essentially propagate values into NaNs at the ends of a sequence if there are fewer than a certain number of NaNs for a given particle).

If we can't use this directly, it's worth noting that these functions are implemented on top of bottleneck.push

@angus-g angus-g added enhancement New feature or request good first issue Good for newcomers labels Jun 9, 2020
@angus-g
Copy link
Owner Author

angus-g commented Jun 29, 2020

Code sample in #61 (comment) is probably a good starting place. Would need to check that this still has the same semantics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant