Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests #3

Open
angus-g opened this issue Jul 29, 2019 · 2 comments
Open

Tests #3

angus-g opened this issue Jul 29, 2019 · 2 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed

Comments

@angus-g
Copy link
Owner

angus-g commented Jul 29, 2019

As a demonstration of the capability of this library, and to make sure we don't break anything, we need tests that can be automatically run in the CI pipeline. Simple (analytical?) and data-minimal tests with "known" answers would be ideal to test the overall algorithm. We can regression/unit test the constituent components too.
@angus-g angus-g added documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed labels Jul 29, 2019
@angus-g
Copy link
Owner Author

angus-g commented Jul 29, 2019

An example "known" test would be a mean flow with an imposed wave component. For this, we should be able to cleanly separate off the wave.

We'd like to test the interaction with topography and boundaries (the particles that do so should probably be deleted, and the filtered point masked off).

@angus-g
Copy link
Owner Author

angus-g commented Aug 26, 2019 •
edited
Loading

This is being handled in the testing branch.

@angus-g angus-g mentioned this issue Aug 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@angus-g