Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs-bug(Sidenav): deprecated methods used in the responsive sidenav example #29266

Open
ysk3a opened this issue Jun 15, 2024 · 1 comment · May be fixed by #29317
Open

docs-bug(Sidenav): deprecated methods used in the responsive sidenav example #29266

ysk3a opened this issue Jun 15, 2024 · 1 comment · May be fixed by #29317
Labels
area: material/sidenav docs This issue is related to documentation good first issue This issue is a good place to start for first time contributors to the project P4 A relatively minor issue that is not relevant to core functions

Comments

@ysk3a
Copy link

ysk3a commented Jun 15, 2024

Documentation Feedback

https://github.com/angular/components/blob/main/src/components-examples/material/sidenav/sidenav-responsive/sidenav-responsive-example.ts

In the stackblitz demo, it shows that addlistener and removelistener are deprecated.
I just wanted to create this documentation issue to let the contributors/maintainers aware.

Affected documentation page

https://material.angular.io/components/sidenav/examples#sidenav-responsive
@ysk3a ysk3a added docs This issue is related to documentation needs triage This issue needs to be triaged by the team labels Jun 15, 2024
@crisbeto
Copy link
Member

We should just use the CDK instead of setting up the media query ourselves.

@crisbeto crisbeto added P4 A relatively minor issue that is not relevant to core functions area: material/sidenav good first issue This issue is a good place to start for first time contributors to the project and removed needs triage This issue needs to be triaged by the team labels Jun 17, 2024
lsamboretrorabbit added a commit to lsamboretrorabbit/components that referenced this issue Jun 25, 2024
@lsamboretrorabbit
docs(material/sidenav): Deprecated methods used in the responsive sid…
13ac64e 
…enav example

Fixes the bug in the documentation - Angular Material 'sidenav' component.
Updated the ts file to use the CDK instead of using media queries

Fixes angular#29266
lsamboretrorabbit added a commit to lsamboretrorabbit/components that referenced this issue Jun 25, 2024
@lsamboretrorabbit
docs(material/sidenav): Deprecated methods used in the responsive sid…
38fd52f 
…enav example

Fixes the bug in the documentation - Angular Material 'sidenav' component.
Updated the ts file to use the CDK instead of using media queries

Fixes angular#29266
@lsamboretrorabbit lsamboretrorabbit linked a pull request Jun 25, 2024 that will close this issue
Open
lsamboretrorabbit added a commit to lsamboretrorabbit/components that referenced this issue Jun 27, 2024
@lsamboretrorabbit
docs(material/sidenav): Deprecated methods used in the responsive sid…
91ebc75 
…enav example

Fixes the bug in the documentation - Angular Material 'sidenav' component.
Updated the file 'sidenav-responsive-example' to use the CDK instead of using media queries

Fixes angular#29266
lsamboretrorabbit added a commit to lsamboretrorabbit/components that referenced this issue Jul 1, 2024
@lsamboretrorabbit
docs(material/sidenav): Deprecated methods used in the responsive sid…
4a11697 
…enav example

Fixes the bug in the documentation - Angular Material 'sidenav' component.
Updated the file 'sidenav-responsive-example' to use the CDK instead of using media queries

Fixes angular#29266
lsamboretrorabbit added a commit to lsamboretrorabbit/components that referenced this issue Jul 4, 2024
@lsamboretrorabbit
docs(material/sidenav): Deprecated methods used in the responsive sid…
043595e 
…enav example

Fixes the bug in the documentation - Angular Material 'sidenav' component.
Updated the file 'sidenav-responsive-example' to use the CDK instead of using media queries

Fixes angular#29266
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: material/sidenav docs This issue is related to documentation good first issue This issue is a good place to start for first time contributors to the project P4 A relatively minor issue that is not relevant to core functions
Projects
None yet
Milestone
No milestone
2 participants
@crisbeto @ysk3a