-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(material/sidenav): Deprecated methods used in the responsive sidenav example #29317
base: main
Are you sure you want to change the base?
docs(material/sidenav): Deprecated methods used in the responsive sidenav example #29317
Conversation
…enav example Fixes the bug in the documentation - Angular Material 'sidenav' component. Updated the ts file to use the CDK instead of using media queries Fixes angular#29266
src/components-examples/material/sidenav/sidenav-responsive/sidenav-responsive-example.ts
Outdated
Show resolved
Hide resolved
src/components-examples/material/sidenav/sidenav-responsive/sidenav-responsive-example.html
Outdated
Show resolved
Hide resolved
src/components-examples/material/sidenav/sidenav-responsive/sidenav-responsive-example.html
Outdated
Show resolved
Hide resolved
src/components-examples/material/sidenav/sidenav-responsive/sidenav-responsive-example.html
Outdated
Show resolved
Hide resolved
…enav example Fixes the bug in the documentation - Angular Material 'sidenav' component. Updated the file 'sidenav-responsive-example' to use the CDK instead of using media queries Fixes angular#29266
@crisbeto thank you, i have made updates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, aside from one last comment and resolving the merge conflicts.
src/components-examples/material/sidenav/sidenav-responsive/sidenav-responsive-example.ts
Outdated
Show resolved
Hide resolved
…enav example Fixes the bug in the documentation - Angular Material 'sidenav' component. Updated the file 'sidenav-responsive-example' to use the CDK instead of using media queries Fixes angular#29266
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that there's a merge commit in the PR now. The tooling that we use to merge PRs doesn't allow merge commits. Can you drop it from your branch?
@@ -29,16 +36,27 @@ export class SidenavResponsiveExample implements OnDestroy { | |||
cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.`, | |||
); | |||
|
|||
private _mobileQueryListener: () => void; | |||
mobileQuery: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that this and _breakpointSubscription
aren't used anymore and can be removed.
…enav example Fixes the bug in the documentation - Angular Material 'sidenav' component. Updated the file 'sidenav-responsive-example' to use the CDK instead of using media queries Fixes angular#29266
Fixes the bug in the documentation - Angular Material 'sidenav' component.
Updated the file 'sidenav-responsive-example' to use the CDK instead of using media queries
Fixes #29266