Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seems to fail with [email protected] #13

Open
Gozala opened this issue Oct 9, 2020 · 7 comments
Open

Seems to fail with [email protected] #13

Gozala opened this issue Oct 9, 2020 · 7 comments

Comments

@Gozala
Copy link

Gozala commented Oct 9, 2020

Loaded [email protected] from CDN.
(node:2728) UnhandledPromiseRejectionWarning: TypeError: (e || "").replace is not a function
    at /home/runner/work/_actions/andoshin11/typescript-error-reporter-action/v1.0.2/dist/index.js:16:2442770
    at o.toString (/home/runner/work/_actions/andoshin11/typescript-error-reporter-action/v1.0.2/dist/index.js:16:2442832)
    at i (/home/runner/work/_actions/andoshin11/typescript-error-reporter-action/v1.0.2/dist/index.js:16:2442199)
    at Object.n.issue (/home/runner/work/_actions/andoshin11/typescript-error-reporter-action/v1.0.2/dist/index.js:16:2442259)
    at l (/home/runner/work/_actions/andoshin11/typescript-error-reporter-action/v1.0.2/dist/index.js:16:4067317)
    at Object.n.setFailed (/home/runner/work/_actions/andoshin11/typescript-error-reporter-action/v1.0.2/dist/index.js:16:4068058)
    at /home/runner/work/_actions/andoshin11/typescript-error-reporter-action/v1.0.2/dist/index.js:16:4043297
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
(node:2728) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:2728) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

https://github.com/multiformats/js-multiformats/runs/1232701675

@samjhill
Copy link

also happens to me

@Gozala
Copy link
Author

Gozala commented Nov 9, 2020

@samjhill I end up making bunch of improvements to support [email protected] specifically:

  • Support for 4.0
  • Use TS from dependencies instead of fetching one from cdn
  • Project path support (for mono repos)
  • Support for TS project references

@andoshin11 I'm happy to send pull requests to try and get those changes inn if you're interested. Have note done so, mostly because I end up taking a different approach by getting rid of CDN piece.

@quantizor
Copy link

@Gozala you're welcome to make them against my fork: https://github.com/probablyup/typescript-error-reporter-action

@MarkLyck
Copy link

This is still failing with "typescript": "4.1.3" @andoshin11 any update on this?

@jimmy927
Copy link

@samjhill I end up making bunch of improvements to support [email protected] specifically:

  • Support for 4.0
  • Use TS from dependencies instead of fetching one from cdn
  • Project path support (for mono repos)
  • Support for TS project references

@andoshin11 I'm happy to send pull requests to try and get those changes inn if you're interested. Have note done so, mostly because I end up taking a different approach by getting rid of CDN piece.

I tried to use your fork, like this:

name: Typescript Error Reporter
on: push

jobs:
  test:
    runs-on: ubuntu-latest
    strategy:
      matrix:
        node-version: [15.x]
    steps:
      - uses: actions/checkout@v1
      - name: Use Node.js ${{ matrix.node-version }}
        uses: actions/setup-node@v1
        with:
          node-version: ${{ matrix.node-version }}
      - name: Install dependencies
        run: yarn install --frozen-lockfile
      - name: Typecheck
        uses: probablyup/typescript-error-reporter-action@51b148277c8bafa44b673277b412e98187769daf

But i am getting this error:

Run probablyup/typescript-error-reporter-action@51b148277c8bafa44b673277b412e98187769daf
Error: Error: no lock file found.

Any ideas ?

@Gozala
Copy link
Author

Gozala commented Feb 21, 2021

quantizor/typescript-error-reporter-action@51b1482

this doesn’t look like my fork. If you have issues with my fork please report them in the repo you’re experiencing it with.

As of the error it seems like a yarn install failing because you tell it to use lockfile, but there isn’t one (in the repo)

@computerjazz
Copy link

@Gozala 's fork fixed this issue for me. Thanks!
Looks like there's some confusion in this thread about which fork to use. Here's what I used:

    - name: Typecheck
      uses: gozala/[email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants