We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
There is a wrong documentation on the matcher type of the predefined transformer size/compose/remToDp.
size/compose/remToDp
We can see here that size/compose/remToDp is filtered by isDimension while size/compose/remToSp is filtered by isFontSize.
isDimension
size/compose/remToSp
isFontSize
Which is perfectly correct.
In the meantime, in documentation, we have Matches: token.type === 'isFontSize' for Dp.
Matches: token.type === 'isFontSize'
Just reporting it, because I struggle with it. Unfortunately, I don't have time to do any PR. :/
Change the documentation from Matches: token.type === 'isFontSize' to Matches: token.type === 'dimension'.
Matches: token.type === 'dimension'
Thanks a lot :)
The text was updated successfully, but these errors were encountered:
Successfully merging a pull request may close this issue.
The documentation problem
There is a wrong documentation on the matcher type of the predefined transformer
size/compose/remToDp
.Explanation
We can see here that
size/compose/remToDp
is filtered byisDimension
whilesize/compose/remToSp
is filtered byisFontSize
.Which is perfectly correct.
In the meantime, in documentation, we have
Matches: token.type === 'isFontSize'
for Dp.Just reporting it, because I struggle with it. Unfortunately, I don't have time to do any PR. :/
What expected
Change the documentation from
Matches: token.type === 'isFontSize'
toMatches: token.type === 'dimension'
.Thanks a lot :)
The text was updated successfully, but these errors were encountered: