Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using AAR from gradle overrides app launcher icons #3

Closed
pulimento opened this issue Dec 13, 2014 · 5 comments · May be fixed by #10
Closed

Using AAR from gradle overrides app launcher icons #3

pulimento opened this issue Dec 13, 2014 · 5 comments · May be fixed by #10

Comments

@pulimento
Copy link

When using as a BinTray dependency in Android Studio v1.0.1, app gets its main icon (ic_launcher) from this library instead of app's default icon. This results in app appearing with android-robot default icon.

I've found posts in StackOverflow regarding this issue, but proposed solutions not worked from me.

Please, remove ic_launcher icons from the generated AAR library. Thanks

@jenzz
Copy link

jenzz commented Dec 17, 2014

This is annoying indeed.

@amulyakhare, can you please kill the ic_launcher.png drawables?

They aren't required anyway...

@saket
Copy link

saket commented Dec 28, 2014

Looks like @amulyakhare has abandoned his project :(

@jenzz
Copy link

jenzz commented Jan 9, 2015

I forked this repo and fixed the issue by removing all the ic_launcher drawables.

I don't wanna steel any glory from the author but I've built the .aar file for this library and uploaded it to my local maven repo here on GitHub. Once this library has the issue fixed or if the author will ask me to I will erase the library from my repo right away.

If you wanna use it, you can include it like this:

repositories {
    ...
    maven { url 'https://github.com/jenzz/jenzz-mvn-repo/raw/master/releases' }
}

dependencies {
    ...
    compile 'com.amulyakhare:com.amulyakhare.textdrawable:1.0.0'
}

@pulimento
Copy link
Author

Thanks! @amulyakhare i'm closing this issue now

@amulyakhare
Copy link
Owner

Hi guys,

I am sorry that I have not been able to maintain this project for some time now. I was extremely busy with something else. I have uploaded a new version of the .aar. Will try my best to keep things updated in the future.

Regards,
-Amulya

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants