fix: secure storage unable to read data from keychain #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases, the app could be initialised before secure storage was ready to be read (`isProtectedDataAvailable` was false). This could lead to data seemingly being "lost", while in fact it was just the keychain not being ready to read the data yet. This introduces a workaround that will wait for the keychain to be ready before fully initialising the app.
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/ammarahm-ed/rnmmkv/GWfGcSEzvQZJMAUQNxNtV2MycEBd |
|
@ammarahm-ed If possible, please release this as a patch version if 0.7.0 isn't ready yet, I'd love to deploy this asap :) |
|
I will make a new release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, the app could be initialised before secure storage was ready to be read (
isProtectedDataAvailablewas false, see docs). This could lead to data seemingly being "lost", while in fact it was just the keychain not being ready to read the data yet.This introduces a workaround that will wait for the keychain to be ready before fully initialising the app.
fixes #195