Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Expo compatibility #207

Closed
fobos531 opened this issue Jan 25, 2022 · 8 comments
Closed

[Question] Expo compatibility #207

fobos531 opened this issue Jan 25, 2022 · 8 comments

Comments

@fobos531
Copy link

Hello - first of all, thanks for the awesome library, I'm using it in multiple projects and it's always worked very reliably for me. I scoured the repo for information on Expo support and noticed that it's suggested to eject from Expo to use this library. While this makes perfect sense, with the advent of Expo dev clients and Expo config plugins, it's been increasingly possible to use previously-incompatible libraries with Expo managed workflow. Is that something you think this project and the ecosystem would benefit from? A similar library - react-native-mmkv - has implemented a way to automate the setup of the library in a way that it makes it compatible with Expo - see mrousavy/react-native-mmkv@d0c6f01

Is that something that would possible here as well?

Thanks in advance!

@ammarahm-ed
Copy link
Owner

@fobos531 I will work on this. Seems like this should fix #195

@ammarahm-ed
Copy link
Owner

@fobos531 give it a try with an expo project:

install from master:

 https://github.com/ammarahm-ed/react-native-mmkv-storage.git

then run expo prebuild

@fobos531
Copy link
Author

Thank you for the prompt response! I'm currently a bit busy with real-life stuff but I'll try it as soon as possible

@Wyctus
Copy link

Wyctus commented Mar 4, 2022

install from master:

 https://github.com/ammarahm-ed/react-native-mmkv-storage.git

then run expo prebuild

Hello @ammarahm-ed ,

we tried in our project and seems working fine, thank you for your work!
Is there any plan to publish this version to npm?

@ammarahm-ed
Copy link
Owner

@Wyctus i think the version on npm already published. The master branch is for next release.

@Wyctus
Copy link

Wyctus commented Mar 4, 2022

@ammarahm-ed
Thank you, it works perfectly!
Could you please update the docs, so everybody can know about this great improvement?

@ammarahm-ed
Copy link
Owner

@Wyctus I have updated the docs.

@Wyctus
Copy link

Wyctus commented Apr 3, 2022

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants