Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom comparisonMethod #326

Open
kolodny opened this issue Mar 6, 2023 · 0 comments
Open

Allow custom comparisonMethod #326

kolodny opened this issue Mar 6, 2023 · 0 comments

Comments

@kolodny
Copy link

kolodny commented Mar 6, 2023

I'd like to try out the ssim-cie94 method of @playwright/test. To do that I'd need to be able to provide a custom function to comparisonMethod (as opposed to just the two string options: 'pixelmatch' | 'ssim'). I think this property can accept a function and just execute that function with the same arguments it's already using for the other two methods

const comparisonFn = comparisonMethod === 'ssim' ? ssimMatch : pixelmatch;

Essentially it'll change to this

- const comparisonFn = comparisonMethod === 'ssim' ? ssimMatch : pixelmatch;
+ const comparisonFn = typeof comparisonMethod === 'function' ? comparisonMethod :
+   comparisonMethod === 'ssim' ? ssimMatch : pixelmatch;

This will also make the library more robust to handle other custom diffing strategies moving forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant