-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate odiff with image snapshot #251
Comments
Implementation could reuse what has been done to introduce the ssim diff lib in #220 |
So can i make a pull request for this? |
This issue is stale because it has been open 30 days with no activity. |
@JamesSingleton @anescobar1991 would you be interesting in reviewing/integrating a Pull Request on that topic if @Quintessent and/or I provide a Pull Request to implement an |
This issue is stale because it has been open 30 days with no activity. |
odiff support has been referenced in #210 (comment) |
This issue is stale because it has been open 30 days with no activity. |
@Quintessent Are you still interested to make a PR? From what I see, it should be fairly straight forwards to integrate this: const { compare } = require("odiff-bin");
const { match, reason } = await compare(
"path/to/first/image.png",
"path/to/second/image.png",
"path/to/diff.png"
); |
I am working on a program where we need to run a huge amount of visual tests for big images (full-hd and bigger) and image comparison takes too much time on CI.
Is it possible to use some kind of more performant library like this https://github.com/dmtrKovalenko/odiff with your tool?
The text was updated successfully, but these errors were encountered: