Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate odiff with image snapshot #251

Open
Quintessent opened this issue Jan 30, 2021 · 8 comments
Open

Integrate odiff with image snapshot #251

Quintessent opened this issue Jan 30, 2021 · 8 comments

Comments

@Quintessent
Copy link

I am working on a program where we need to run a huge amount of visual tests for big images (full-hd and bigger) and image comparison takes too much time on CI.

Is it possible to use some kind of more performant library like this https://github.com/dmtrKovalenko/odiff with your tool?

@tbouffard
Copy link

tbouffard commented Feb 1, 2021

Implementation could reuse what has been done to introduce the ssim diff lib in #220

@Quintessent
Copy link
Author

So can i make a pull request for this?

@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity.

@tbouffard
Copy link

tbouffard commented Mar 19, 2021

@JamesSingleton @anescobar1991 would you be interesting in reviewing/integrating a Pull Request on that topic if @Quintessent and/or I provide a Pull Request to implement an odiff integration?

@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity.

@tbouffard
Copy link

odiff support has been referenced in #210 (comment)

@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity.

@tujoworker
Copy link

@Quintessent Are you still interested to make a PR?

From what I see, it should be fairly straight forwards to integrate this:

const { compare } = require("odiff-bin");

const { match, reason } = await compare(
  "path/to/first/image.png",
  "path/to/second/image.png",
  "path/to/diff.png"
);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants