[FIX] Remove last_request_end_time predicate #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@amachanic not sure what happened here, but essentially the whole PR is a conflict. It might be easier to re-base and make the one change again. |
I removed all of the tabs and switched to spaces. |
Yeah, I caught that PR, but the diff wasn't loading here for a bit. Would you prefer to rebase with the spaces commit in place or just resolve this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this will fix various bugs. On the flip side, I have no idea what problems it will cause. This predicate was in place for about a decade and I can't remember why I put it in place.