-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ruby Version - necessary for tzf gem #41
Comments
I'm giving my feedback now on trying to rub the project locally, not on Codespaces: |
I would also note that the Gemfile.lock file in the main branch has TZF version (0.2.5), while the TZF version in Gemfile.lock of the "availability_tweet" branch is tzf (0.1.0) When I run bundle install on the main branch with Ruby versions higher than 3.0 I've seen Bundler try to intall versions 0.2.6 and 0.4.0 of TZF. However running |
The TZF Repo says that it uses the tzf-rs Rust library. It's not explicit in this screenshot, but I have Rust installed. However, installing TZF still fails |
I wonder if TZF has been working for @alterisian and @Animesh-Ghosh because an older version was installed (version 0.1.0 or 0.2.5) in combination with using Ruby version 3.0.1 or 3.0.2 ? However, I have not yet tried |
I did try GitHub Codespaces on Thursday on the original Repo. Codespaces starts on the main branch by default and it had Ruby version 3.1.4 installed. This also would not work with TZF with That is my feedback thus far. I believe that we could setup some defaults for our codespaces dev containers for this project, but I havn't looked into further. |
I believe that in the current state the TZF gem poses a barrier to entry for anyone new joining our project. Like @alterisian mentioned it'd be important to get this sorted. |
Development Containers & GitHub Codespaces should kill the “works on my machine” problem. |
We should only have the main branch. Lets merge all branches into main on Wednesday this week, and fix at ruby 3.0.2 via the .ruby-version file only. If we use temporary feature branches can they be merged at the end of the session. Dev on main is fine if we do small and tested steps :) |
Which method on spike is useful aninmesh? Perhaps we can adapt the code to use the timeanddate api. Lets merge it into main asap, and kill the branch. |
Didn't get this.
Yeah, we can switch to this, not sure if their API is paid or not. One work-around that I found was maybe utilizing this endpoint however their README may or may not be reliable. |
Hi all
I don't know yet which condition makes most sense, but then we could all use the same Gemfile again without TZF causing issues for some. |
We're using the tzf gem to establish who is in the current timezone when the mob is active.
And also the idea, would be for the next timezone too.
I guess there's two aspects to the problem. Until now, a version has not mattered.
Now we find some later versions do not work, and some earlier versions are preferred.
We have a .ruby-version file in the repo now, and this needs to be set to the version that does work for this gem.
(My understanding is that if we have this, then we do not need the one in the Gemfile - happy to be corrected though).
Ruby 3.0.2 seems to work on Ubuntu 22, with rbenv.
I think myself and @Animesh-Ghosh confirmed this on codespaces.
However, when @Georgy5 and @mmiy55 tried the version was still going to 3.1.4
(We're unsure if this is because codespaces was started in the main branch.)
TODO-check with .ruby-version set to 3.0.2 that codespaces does not load 3.1.4
Important to get this feature branch, merged in asap, then we do not have the confusion problem at least.
(Maybe generally we try to work on main unless there's a production server involved, but a branch could be considered max a 2 week lifespan?)
In our exploring of timezones I've found https://timeanddate.com to be the best site. It also has an api we could use as an alternative: https://www.timeanddate.com/services/api/
The text was updated successfully, but these errors were encountered: