Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close socket on disconnect #148

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Close socket on disconnect #148

wants to merge 1 commit into from

Conversation

elParaguayo
Copy link
Contributor

As per issue #137, sockets are not closed when the bus is disconnected. This results in users receiving warnings about unclosed sockets.

This PR adds a call to the socket's close method during disconnect.

Closes #137

@elParaguayo
Close socket on disconnect
1c13ced 
As per issue altdesktop#137, sockets are not closed when the bus is disconnected.
This results in users receiving warnings about unclosed sockets.

This PR adds a call to the socket's `close` method during `disconnect`.

Closes altdesktop#137
@elParaguayo
Copy link
Contributor Author

Not sure why test_tcp_connection_with_forwarding fails as it doesn't call bus.disconnect which is the only code I've changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot close underlying sockets
1 participant
@elParaguayo