Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stretch] Review the overlap of the different types representing a component class in our code #5469

Open
1 task
Tracked by #5373
romaricpascal opened this issue Nov 4, 2024 · 0 comments

Comments

@romaricpascal
Copy link
Member

romaricpascal commented Nov 4, 2024

What

Review the types representing a component class across our codebase and:

  • make sure their names are unique and expressive
  • shared concepts are named appropriately and reused as needed.

Why

The work on configuration will introduce another type to represent a partial component class. It seems it’ll have some overlap with the one used by createAll, as well as the one used in GOVUKFrontendComponent.

Keeping things tidy and nicely named will help us understand what's going on in the long run.

Who needs to work on this

Developers

Who needs to review this

Developers

Done when

  • We've reviewed the types and updated them as necessary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog 🏃🏼‍♀️
Development

No branches or pull requests

1 participant