Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New typography scale causes wrapping of OGL text in footer #5290

Closed
matteason opened this issue Sep 3, 2024 · 2 comments · Fixed by #5332
Closed

New typography scale causes wrapping of OGL text in footer #5290

matteason opened this issue Sep 3, 2024 · 2 comments · Fixed by #5332
Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation) design footer sass / css small story typography

Comments

@matteason
Copy link
Contributor

matteason commented Sep 3, 2024 •
edited
Loading

#4064 (later feature-flagged: 5fcf176) increased the footer font size to 19px, which means the OGL licence text in the footer now wraps when viewed at full width at the default zoom level/text size:

Before (16px)
GOV.UK footer with text on one line: All content is available under the Open Government Licence v3.0), except where otherwise stated

After (19px)
GOV.UK footer with text on two lines, the last word on the second line: All content is available under the Open Government Licence v3.0

You can see this live on https://design-system.service.gov.uk/patterns/question-pages/default/

Typographically this looks a bit strange as it makes stated an orphan
@matteason matteason added awaiting triage Needs triaging by team 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) labels Sep 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024

Uh oh! @matteason, the image you shared is missing helpful alt text. Check your issue body.

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

🤖 Beep boop! This comment was added automatically by github/accessibility-alt-text-bot.

@romaricpascal romaricpascal mentioned this issue Sep 17, 2024
Merged
@romaricpascal romaricpascal mentioned this issue Sep 17, 2024
Open
@romaricpascal romaricpascal moved this to Needs review 🔍 in GOV.UK Design System cycle board Sep 17, 2024
@romaricpascal
Copy link
Member

Hi @matteason, thanks for flagging that. I've proposed a fix in this draft PR, but it raises a few questions I'd like to put to the different specialists in the team so it may take a little before we fix the issue 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation) design footer sass / css small story typography
Projects
GOV.UK Design System cycle board
Status: Needs review 🔍
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve how licence description wraps in the footer alphagov/govuk-frontend
2 participants
@romaricpascal @matteason