Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Jetpack CDN to Service Images #1169

Open
efuller opened this issue Sep 20, 2024 · 1 comment
Open

Allow Jetpack CDN to Service Images #1169

efuller opened this issue Sep 20, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request php Requires understanding PHP

Comments

@efuller
Copy link

efuller commented Sep 20, 2024

Description

Currently, if a site is using Jetpack boost to serve up images, when a cover image is set to be used, the image is served from the origin, not the Jetpack boost CDN.

There is code in place that strips out the Jetpack CDN URL. This code should be removed and we should use what WordPress gives us natively.

Use Case

When a user sets an Apple News cover image it is served with the correct URL. If Jetpack Boost is being used, it should serve the image from the CDN

@efuller efuller added enhancement New feature or request php Requires understanding PHP labels Sep 20, 2024
@efuller efuller self-assigned this Sep 20, 2024
@efuller
Copy link
Author

efuller commented Oct 16, 2024

A working branch has been created - https://github.com/alleyinteractive/apple-news/tree/feature/allow-jetpack-cdn-serve-images - which includes a fix. If I recall, there will need to be a bit more work done in order for unit tests to pass.

I would also recommend a round of manual testing as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request php Requires understanding PHP
Projects
None yet
Development

No branches or pull requests

1 participant