Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: 1.8.0 has breaking undocumented API change #452

Open
dvershinin opened this issue Sep 15, 2024 · 0 comments
Open

[Bug]: 1.8.0 has breaking undocumented API change #452

dvershinin opened this issue Sep 15, 2024 · 0 comments

Comments

@dvershinin
Copy link

What happened?

I tried to compile Tengine with xquic 1.8.0 and surely it failed

Steps To Reproduce

Compile Tengine with xquic 1.8.0. It choked on few arguments passed to xqc_scid_str.
Even without checking with Tengine code, we can see that documentation here has:

unsigned char *xqc_scid_str(const xqc_cid_t *scid);

While the code for xquic 1.8.0 here:

unsigned char *
xqc_scid_str(xqc_engine_t *engine, const xqc_cid_t *scid)
{
    xqc_hex_dump(engine->scid_buf, scid->cid_buf, scid->cid_len);
    engine->scid_buf[scid->cid_len * 2] = '\0';
    return engine->scid_buf;
}

Thus there are 2 issues:

  • xquic 1.8.0 is not compatible with Tengine
  • documentation doesn't reflect actual API, not updated

Relevant log output

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant