Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improve][client] Reuse field getters in all the CompletedFetch of same table. #227

Open
2 tasks done
loserwang1024 opened this issue Dec 19, 2024 · 0 comments · May be fixed by #242
Open
2 tasks done

[Improve][client] Reuse field getters in all the CompletedFetch of same table. #227

loserwang1024 opened this issue Dec 19, 2024 · 0 comments · May be fixed by #242
Labels
feature New feature or request

Comments

@loserwang1024
Copy link
Collaborator

Search before asking

  • I searched in the issues and found nothing similar.

Motivation

Current, though all the CompletedFetch will share same rowType from same readContext, fieldGetters will still be initialized for each CompletedFetch（even CompletedFetch contains empty data) . If the table has hundreds of column, it costs a lot.

Solution

Reuse field getters in all the CompletedFetch of same table.

Anything else?

No response

Willingness to contribute

  • I'm willing to submit a PR!
@loserwang1024 loserwang1024 added the feature New feature or request label Dec 19, 2024
@loserwang1024 loserwang1024 linked a pull request Dec 20, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[client] Reuse field getters in all the CompletedFetch of same table. loserwang1024/fluss
1 participant
@loserwang1024