Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animated List #299

Open
jasin755 opened this issue Jun 10, 2019 · 3 comments
Open

Animated List #299

jasin755 opened this issue Jun 10, 2019 · 3 comments
Labels
good first issue Good for newcomers

Comments

@jasin755
Copy link

Hi. I have wanted to create animated list. I tried many examples but none of them works with fish redux. Can you show some example?

Thanks

@zjuwjf zjuwjf added the good first issue Good for newcomers label Jun 10, 2019
@zjuwjf
Copy link
Contributor

zjuwjf commented Jun 12, 2019

Sorry to reply to your question so late.

I read the source code of Animated List and its examples. It is a bit awkward to express and control in the fish-redux pattern, especially in conjunction with the adapter.

The main reasons are as follows

  1. Animated List is not a widget for reactive expression. In other words, it is difficult to express it in a pure function.

  2. Its "remoeItem" api is too difficult to use. The api must set an AnimatedListRemovedItemBuilder parameter is confusing.

@jasin755
Copy link
Author

It's big blocker for using fish-redux :/

@hacker1024
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants