Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS - Interface with wrong colors in Dark Mode #25

Open
mg-1999 opened this issue Mar 4, 2020 · 4 comments
Open

iOS - Interface with wrong colors in Dark Mode #25

mg-1999 opened this issue Mar 4, 2020 · 4 comments

Comments

@mg-1999
Copy link

mg-1999 commented Mar 4, 2020

See attached images

IMG_0293
IMG_0294

@cbellone
Copy link
Member

cbellone commented Mar 4, 2020

Hi @mg-1999
this is WIP, we're almost ready to release the new version.
Can you please test it using the following link: https://testflight.apple.com/join/glG9ICZT

Thank you!

@mg-1999
Copy link
Author

mg-1999 commented Mar 4, 2020

@cbellone colors are fixed. Only in dark mode the colors are wrong. I thinks it picks the colors of Android Darkmode instead of Apple's version

@cbellone
Copy link
Member

cbellone commented Mar 4, 2020

Interesting, I didn't notice it. Thank you very much for pointing it out.

Since we use a cross platform framework for building the app, we inherit the theme settings.
I think your assumption is correct, as they use the same color for the background: #303030 (https://github.com/NativeScript/theme/blob/master/src/scss/variables/_index.scss#L11)

The good news is that we can override the setting on iOS, so I'll dig a bit to find the official style guide from apple

Will be back to you as soon as I know more :)

thanks

@mg-1999
Copy link
Author

mg-1999 commented Mar 4, 2020

Maybe this will steer you in the right direction:
https://developer.apple.com/design/human-interface-guidelines/ios/visual-design/dark-mode/

cbellone added a commit that referenced this issue Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants