From 416ade40ba569472e638221f9488e04399e1e948 Mon Sep 17 00:00:00 2001 From: Clay Hayes Date: Thu, 9 Nov 2023 15:35:52 -0600 Subject: [PATCH 1/6] Add godrorstore --- godrorstore/README.md | 111 +++++++++++++++++++++++++++++ godrorstore/go.mod | 5 ++ godrorstore/godrorstore.go | 139 +++++++++++++++++++++++++++++++++++++ 3 files changed, 255 insertions(+) create mode 100644 godrorstore/README.md create mode 100644 godrorstore/go.mod create mode 100644 godrorstore/godrorstore.go diff --git a/godrorstore/README.md b/godrorstore/README.md new file mode 100644 index 0000000..a8b6a64 --- /dev/null +++ b/godrorstore/README.md @@ -0,0 +1,111 @@ +# godrorstore + +An Oracle Database based session store for [SCS](https://github.com/alexedwards/scs) using the [godror](https://github.com/godror/godror) driver. + +## Setup + +You should have a working Oracle database containing a `sessions` table with the definition: + +```sql +CREATE TABLE sessions ( + token varchar(250) PRIMARY KEY, + data BLOB NOT NULL, + expiry TIMESTAMP NOT NULL +); + +CREATE INDEX sessions_expiry_idx ON sessions (expiry); +``` + +The database user for your application must have `SELECT`, `INSERT`, `UPDATE` and `DELETE` permissions on this table. + +## Example + +```go +package main + +import ( + "database/sql" + "io" + "log" + "net/http" + + "github.com/alexedwards/scs/v2" + "github.com/alexedwards/scs/godrorstore" + + _ "github.com/godror/godror" +) + +var sessionManager *scs.SessionManager + +func main() { + // Configure connection string. + username := "username" + password := "password" + host := "example.com" + port := "port" // Normally 1521 + service := "service.world" + connStr := fmt.Sprintf(`user="%s" password="%s" connectString="%s:%s/%s" timezone="+0000"`, username, password, host, port, service) + + // Establish connection to Oracle Database. + db, err := sql.Open("godror", connStr) + if err != nil { + log.Fatal(err) + } + defer db.Close() + + // Initialize a new session manager and configure it to use godrorstore as the session store. + sessionManager = scs.New() + sessionManager.Store = godrorstore.New(db) + + mux := http.NewServeMux() + mux.HandleFunc("/put", putHandler) + mux.HandleFunc("/get", getHandler) + + http.ListenAndServe(":4000", sessionManager.LoadAndSave(mux)) +} + +func putHandler(w http.ResponseWriter, r *http.Request) { + sessionManager.Put(r.Context(), "message", "Hello from a session!") +} + +func getHandler(w http.ResponseWriter, r *http.Request) { + msg := sessionManager.GetString(r.Context(), "message") + io.WriteString(w, msg) +} +``` + +## Expired Session Cleanup + +This package provides a background 'cleanup' goroutine to delete expired session data. This stops the database table from holding on to invalid sessions indefinitely and growing unnecessarily large. By default the cleanup runs every 5 minutes. You can change this by using the `NewWithCleanupInterval()` function to initialize your session store. For example: + +```go +// Run a cleanup every 30 minutes. +godrorstore.NewWithCleanupInterval(db, 30*time.Minute) + +// Disable the cleanup goroutine by setting the cleanup interval to zero. +godrorstore.NewWithCleanupInterval(db, 0) +``` + +### Terminating the Cleanup Goroutine + +It's rare that the cleanup goroutine needs to be terminated --- it is generally intended to be long-lived and run for the lifetime of your application. + +However, there may be occasions when your use of a session store instance is transient. A common example would be using it in a short-lived test function. In this scenario, the cleanup goroutine (which will run forever) will prevent the session store instance from being garbage collected even after the test function has finished. You can prevent this by either disabling the cleanup goroutine altogether (as described above) or by stopping it using the `StopCleanup()` method. For example: + +```go +func TestExample(t *testing.T) { + db, err := sql.Open("godror", connStr) + if err != nil { + t.Fatal(err) + } + defer db.Close() + + store := godrorstore.New(db) + defer store.StopCleanup() + + sessionManager = scs.New() + sessionManager.Store = store + + // Run test... +} +``` \ No newline at end of file diff --git a/godrorstore/go.mod b/godrorstore/go.mod new file mode 100644 index 0000000..5758df5 --- /dev/null +++ b/godrorstore/go.mod @@ -0,0 +1,5 @@ +module github.com/chayes/scs/godrorstore + +go 1.20 + +require github.com/godror/godror v0.39.0 \ No newline at end of file diff --git a/godrorstore/godrorstore.go b/godrorstore/godrorstore.go new file mode 100644 index 0000000..9f52556 --- /dev/null +++ b/godrorstore/godrorstore.go @@ -0,0 +1,139 @@ +package godrorstore + +import ( + "database/sql" + "fmt" + "log" + "time" +) + +type GodrorStore struct { + db *sql.DB + stopCleanup chan bool +} + +func New(db *sql.DB) *GodrorStore { + return NewWithCleanupInterval(db, 5*time.Minute) +} + +func NewWithCleanupInterval(db *sql.DB, cleanupInterval time.Duration) *GodrorStore { + g := &GodrorStore{db: db} + if cleanupInterval > 0 { + go g.StartCleanup(cleanupInterval) + } + return g +} + +func (g *GodrorStore) Find(token string) (b []byte, exists bool, err error) { + fmt.Println("Find") + stmt := `SELECT data FROM sessions WHERE token = '` + token + `' AND current_timestamp < expiry` + row := g.db.QueryRow(stmt) + err = row.Scan(&b) + if err == sql.ErrNoRows { + return nil, false, nil + } else if err != nil { + return nil, false, err + } + return b, true, nil +} + +func (g *GodrorStore) Commit(token string, b []byte, expiry time.Time) error { + fmt.Println("Commit") + stmt := `SELECT data FROM sessions WHERE token = '` + token + `'` + row := g.db.QueryRow(stmt) + err := row.Err() + if row.Scan() == sql.ErrNoRows { + fmt.Println("No Row Found") + stmt = `INSERT INTO sessions (token, data, expiry) VALUES ('` + token + `', '%x', to_timestamp('` + string(expiry.Format("2006-01-02 15:04:05.00")) + `', 'YYYY-MM-DD HH24:MI:SS.FF'))` + stmt = fmt.Sprintf(stmt, b) + fmt.Println(stmt) + _, err := g.db.Exec(stmt) + if err != nil { + return err + } + return nil + } else if err != nil { + fmt.Println("Other error") + return err + } + + fmt.Println("Update session data") + stmt = `UPDATE sessions SET data = '%x', expiry = to_timestamp('` + string(expiry.Format("2006-01-02 15:04:05.00")) + `', 'YYYY-MM-DD HH24:MI:SS.FF') WHERE token = '` + token + `'` + stmt = fmt.Sprintf(stmt, b) + _, err = g.db.Exec(stmt) + if err != nil { + return err + } + + return nil +} + +func (g *GodrorStore) Delete(token string) error { + fmt.Println("Delete") + stmt := `DELETE FROM session WHERE token = '` + token + `'` + _, err := g.db.Exec(stmt) + return err +} + +func (g *GodrorStore) All() (map[string][]byte, error) { + fmt.Println("All") + rows, err := g.db.Query("SELECT token, data FROM sessions WHERE current_timestamp < expiry") + if err != nil { + return nil, err + } + defer rows.Close() + + sessions := make(map[string][]byte) + + for rows.Next() { + var ( + token string + data []byte + ) + + err = rows.Scan(&token, &data) + if err != nil { + return nil, err + } + + sessions[token] = data + } + + err = rows.Err() + if err != nil { + return nil, err + } + + return sessions, nil +} + +func (g *GodrorStore) StartCleanup(interval time.Duration) { + fmt.Println("StartCleanup") + g.stopCleanup = make(chan bool) + ticker := time.NewTicker(interval) + for { + select { + case <-ticker.C: + err := g.deleteExpired() + if err != nil { + log.Println(err) + } + case <-g.stopCleanup: + ticker.Stop() + return + } + } +} + +func (g *GodrorStore) StopCleanup() { + fmt.Println("StopCleanup") + if g.stopCleanup != nil { + g.stopCleanup <- true + } +} + +func (g *GodrorStore) deleteExpired() error { + fmt.Println("deleteExpired") + _, err := g.db.Exec("DELETE FROM sessions WHERE expiry < current_timestamp") + return err +} From e72247a0648051680ae1afd3d922704505431968 Mon Sep 17 00:00:00 2001 From: Clay Hayes Date: Thu, 9 Nov 2023 15:37:44 -0600 Subject: [PATCH 2/6] Make port number more clear. --- godrorstore/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/godrorstore/README.md b/godrorstore/README.md index a8b6a64..35c3e97 100644 --- a/godrorstore/README.md +++ b/godrorstore/README.md @@ -42,7 +42,7 @@ func main() { username := "username" password := "password" host := "example.com" - port := "port" // Normally 1521 + port := "12345" // Normally 1521 service := "service.world" connStr := fmt.Sprintf(`user="%s" password="%s" connectString="%s:%s/%s" timezone="+0000"`, username, password, host, port, service) From 7e0113a9b470038198733135abdc5e1d9ea74698 Mon Sep 17 00:00:00 2001 From: Clay Hayes Date: Thu, 9 Nov 2023 16:24:15 -0600 Subject: [PATCH 3/6] Create unit tests --- godrorstore/godrorstore_test.go | 271 ++++++++++++++++++++++++++++++++ 1 file changed, 271 insertions(+) create mode 100644 godrorstore/godrorstore_test.go diff --git a/godrorstore/godrorstore_test.go b/godrorstore/godrorstore_test.go new file mode 100644 index 0000000..dc1a7eb --- /dev/null +++ b/godrorstore/godrorstore_test.go @@ -0,0 +1,271 @@ +package godrorstore + +import ( + "bytes" + "database/sql" + "os" + "reflect" + "testing" + "time" +) + +func TestFind(t *testing.T) { + dsn := os.Getenv("SCS_GODROR_TEST_DSN") + db, err := sql.Open("godror", dsn) + if err != nil { + t.Fatal(err) + } + defer db.Close() + if err := db.Ping(); err != nil { + t.Fatal(err) + } + _, err := db.Exec("TRUNCATE TABLE sessions") + if err != nil { + t.Fatal(err) + } + _, err := db.Exec("INSERT INTO sessions VALUES('session_token', 'encoded_data', current_timestamp + interval '1 minute')") + if err != nil { + t.Fatal(err) + } + + g := NewWithCleanupInterval(db, 0) + + b, found, err := g.Find("session_token") + if err != nil { + t.Fatal(err) + } + if found != true { + t.Fatalf("got %v: expected %v", found, true) + } + if bytes.Equal(b, []byte("encoded_data")) == false { + t.Fatalf("got %v: expected %v", b, []byte("encoded_data")) + } +} + +func TestFindMissing(t *testing.T) { + dsn := os.Getenv("SCS_GODROR_TEST_DSN") + db, err := sql.Open("godror", dsn) + if err != nil { + t.Fatal(err) + } + defer db.Close() + if err = db.Ping(); err != nil { + t.Fatal(err) + } + _, err = db.Exec("TRUNCATE TABLE sessions") + if err != nil { + t.Fatal(err) + } + + g := NewWithCleanupInterval(db, 0) + + _, found, err := g.Find("missing_session_token") + if err != nil { + t.Fatalf("got %v: expected %v", err, nil) + } + if found != false { + t.Fatalf("got %v: expected %v", found, false) + } +} + +func TestSaveNew(t *testing.T) { + dsn := os.Getenv("SCS_GODROR_TEST_DSN") + db, err := sql.Open("godror", dsn) + if err != nil { + t.Fatal(err) + } + defer db.Close() + if err = db.Ping(); err != nil { + t.Fatal(err) + } + _, err = db.Exec("TRUNCATE TABLE sessions") + if err != nil { + t.Fatal(err) + } + + p := NewWithCleanupInterval(db, 0) + + err = p.Commit("session_token", []byte("encoded_data"), time.Now().Add(time.Minute)) + if err != nil { + t.Fatal(err) + } + + row := db.QueryRow("SELECT data FROM sessions WHERE token = 'session_token'") + var data []byte + err = row.Scan(&data) + if err != nil { + t.Fatal(err) + } + if reflect.DeepEqual(data, []byte("encoded_data")) == false { + t.Fatalf("got %v: expected %v", data, []byte("encoded_data")) + } +} + +func TestSaveUpdated(t *testing.T) { + dsn := os.Getenv("SCS_GODROR_TEST_DSN") + db, err := sql.Open("godror", dsn) + if err != nil { + t.Fatal(err) + } + defer db.Close() + if err = db.Ping(); err != nil { + t.Fatal(err) + } + _, err = db.Exec("TRUNCATE TABLE sessions") + if err != nil { + t.Fatal(err) + } + _, err = db.Exec("INSERT INTO sessions VALUES('session_token', 'encoded_data', current_timestamp + interval '1 minute')") + if err != nil { + t.Fatal(err) + } + + p := NewWithCleanupInterval(db, 0) + + err = p.Commit("session_token", []byte("new_encoded_data"), time.Now().Add(time.Minute)) + if err != nil { + t.Fatal(err) + } + + row := db.QueryRow("SELECT data FROM sessions WHERE token = 'session_token'") + var data []byte + err = row.Scan(&data) + if err != nil { + t.Fatal(err) + } + if reflect.DeepEqual(data, []byte("new_encoded_data")) == false { + t.Fatalf("got %v: expected %v", data, []byte("new_encoded_data")) + } +} + +func TestExpiry(t *testing.T) { + dsn := os.Getenv("SCS_GODROR_TEST_DSN") + db, err := sql.Open("godror", dsn) + if err != nil { + t.Fatal(err) + } + defer db.Close() + if err = db.Ping(); err != nil { + t.Fatal(err) + } + _, err = db.Exec("TRUNCATE TABLE sessions") + if err != nil { + t.Fatal(err) + } + + p := NewWithCleanupInterval(db, 0) + + err = p.Commit("session_token", []byte("encoded_data"), time.Now().Add(100*time.Millisecond)) + if err != nil { + t.Fatal(err) + } + + _, found, _ := p.Find("session_token") + if found != true { + t.Fatalf("got %v: expected %v", found, true) + } + + time.Sleep(100 * time.Millisecond) + _, found, _ = p.Find("session_token") + if found != false { + t.Fatalf("got %v: expected %v", found, false) + } +} + +func TestDelete(t *testing.T) { + dsn := os.Getenv("SCS_GODROR_TEST_DSN") + db, err := sql.Open("godror", dsn) + if err != nil { + t.Fatal(err) + } + defer db.Close() + if err = db.Ping(); err != nil { + t.Fatal(err) + } + _, err = db.Exec("TRUNCATE TABLE sessions") + if err != nil { + t.Fatal(err) + } + _, err = db.Exec("INSERT INTO sessions VALUES('session_token', 'encoded_data', current_timestamp + interval '1 minute')") + if err != nil { + t.Fatal(err) + } + + p := NewWithCleanupInterval(db, 0) + + err = p.Delete("session_token") + if err != nil { + t.Fatal(err) + } + + row := db.QueryRow("SELECT COUNT(*) FROM sessions WHERE token = 'session_token'") + var count int + err = row.Scan(&count) + if err != nil { + t.Fatal(err) + } + if count != 0 { + t.Fatalf("got %d: expected %d", count, 0) + } +} + +func TestCleanup(t *testing.T) { + dsn := os.Getenv("SCS_GODROR_TEST_DSN") + db, err := sql.Open("godror", dsn) + if err != nil { + t.Fatal(err) + } + defer db.Close() + if err = db.Ping(); err != nil { + t.Fatal(err) + } + _, err = db.Exec("TRUNCATE TABLE sessions") + if err != nil { + t.Fatal(err) + } + + p := NewWithCleanupInterval(db, 200*time.Millisecond) + defer p.StopCleanup() + + err = p.Commit("session_token", []byte("encoded_data"), time.Now().Add(100*time.Millisecond)) + if err != nil { + t.Fatal(err) + } + + row := db.QueryRow("SELECT COUNT(*) FROM sessions WHERE token = 'session_token'") + var count int + err = row.Scan(&count) + if err != nil { + t.Fatal(err) + } + if count != 1 { + t.Fatalf("got %d: expected %d", count, 1) + } + + time.Sleep(300 * time.Millisecond) + row = db.QueryRow("SELECT COUNT(*) FROM sessions WHERE token = 'session_token'") + err = row.Scan(&count) + if err != nil { + t.Fatal(err) + } + if count != 0 { + t.Fatalf("got %d: expected %d", count, 0) + } +} + +func TestStopNilCleanup(t *testing.T) { + dsn := os.Getenv("SCS_GODROR_TEST_DSN") + db, err := sql.Open("godror", dsn) + if err != nil { + t.Fatal(err) + } + defer db.Close() + if err = db.Ping(); err != nil { + t.Fatal(err) + } + + p := NewWithCleanupInterval(db, 0) + time.Sleep(100 * time.Millisecond) + // A send to a nil channel will block forever + p.StopCleanup() +} From fd43cf774e7b027da9310f6a746132d1191bf797 Mon Sep 17 00:00:00 2001 From: Clay Hayes Date: Mon, 13 Nov 2023 09:27:54 -0600 Subject: [PATCH 4/6] Fix vulnerability in passing token to SQL --- godrorstore/godrorstore.go | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/godrorstore/godrorstore.go b/godrorstore/godrorstore.go index 9f52556..876dc6f 100644 --- a/godrorstore/godrorstore.go +++ b/godrorstore/godrorstore.go @@ -26,7 +26,7 @@ func NewWithCleanupInterval(db *sql.DB, cleanupInterval time.Duration) *GodrorSt func (g *GodrorStore) Find(token string) (b []byte, exists bool, err error) { fmt.Println("Find") - stmt := `SELECT data FROM sessions WHERE token = '` + token + `' AND current_timestamp < expiry` + stmt := fmt.Sprintf("SELECT data FROM sessions WHERE token = '%x' AND current_timestamp < expiry", token) row := g.db.QueryRow(stmt) err = row.Scan(&b) if err == sql.ErrNoRows { @@ -39,13 +39,13 @@ func (g *GodrorStore) Find(token string) (b []byte, exists bool, err error) { func (g *GodrorStore) Commit(token string, b []byte, expiry time.Time) error { fmt.Println("Commit") - stmt := `SELECT data FROM sessions WHERE token = '` + token + `'` + stmt := fmt.Sprintf("SELECT data FROM sessions WHERE token = '%x'", token) row := g.db.QueryRow(stmt) err := row.Err() if row.Scan() == sql.ErrNoRows { fmt.Println("No Row Found") - stmt = `INSERT INTO sessions (token, data, expiry) VALUES ('` + token + `', '%x', to_timestamp('` + string(expiry.Format("2006-01-02 15:04:05.00")) + `', 'YYYY-MM-DD HH24:MI:SS.FF'))` - stmt = fmt.Sprintf(stmt, b) + stmt = `INSERT INTO sessions (token, data, expiry) VALUES ('%x', '%x', to_timestamp('` + string(expiry.Format("2006-01-02 15:04:05.00")) + `', 'YYYY-MM-DD HH24:MI:SS.FF'))` + stmt = fmt.Sprintf(stmt, token, b) fmt.Println(stmt) _, err := g.db.Exec(stmt) if err != nil { @@ -58,8 +58,8 @@ func (g *GodrorStore) Commit(token string, b []byte, expiry time.Time) error { } fmt.Println("Update session data") - stmt = `UPDATE sessions SET data = '%x', expiry = to_timestamp('` + string(expiry.Format("2006-01-02 15:04:05.00")) + `', 'YYYY-MM-DD HH24:MI:SS.FF') WHERE token = '` + token + `'` - stmt = fmt.Sprintf(stmt, b) + stmt = `UPDATE sessions SET data = '%x', expiry = to_timestamp('` + string(expiry.Format("2006-01-02 15:04:05.00")) + `', 'YYYY-MM-DD HH24:MI:SS.FF') WHERE token = '%x'` + stmt = fmt.Sprintf(stmt, b, token) _, err = g.db.Exec(stmt) if err != nil { return err @@ -70,7 +70,7 @@ func (g *GodrorStore) Commit(token string, b []byte, expiry time.Time) error { func (g *GodrorStore) Delete(token string) error { fmt.Println("Delete") - stmt := `DELETE FROM session WHERE token = '` + token + `'` + stmt := fmt.Sprintf("DELETE FROM session WHERE token = '%x'", token) _, err := g.db.Exec(stmt) return err } From d5d10bf94a0b65590b292703f367ab2836abf552 Mon Sep 17 00:00:00 2001 From: Clay Hayes Date: Mon, 13 Nov 2023 10:07:31 -0600 Subject: [PATCH 5/6] Removed all println debugging --- godrorstore/godrorstore.go | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/godrorstore/godrorstore.go b/godrorstore/godrorstore.go index 876dc6f..73d2d1a 100644 --- a/godrorstore/godrorstore.go +++ b/godrorstore/godrorstore.go @@ -25,7 +25,6 @@ func NewWithCleanupInterval(db *sql.DB, cleanupInterval time.Duration) *GodrorSt } func (g *GodrorStore) Find(token string) (b []byte, exists bool, err error) { - fmt.Println("Find") stmt := fmt.Sprintf("SELECT data FROM sessions WHERE token = '%x' AND current_timestamp < expiry", token) row := g.db.QueryRow(stmt) err = row.Scan(&b) @@ -38,12 +37,10 @@ func (g *GodrorStore) Find(token string) (b []byte, exists bool, err error) { } func (g *GodrorStore) Commit(token string, b []byte, expiry time.Time) error { - fmt.Println("Commit") stmt := fmt.Sprintf("SELECT data FROM sessions WHERE token = '%x'", token) row := g.db.QueryRow(stmt) err := row.Err() if row.Scan() == sql.ErrNoRows { - fmt.Println("No Row Found") stmt = `INSERT INTO sessions (token, data, expiry) VALUES ('%x', '%x', to_timestamp('` + string(expiry.Format("2006-01-02 15:04:05.00")) + `', 'YYYY-MM-DD HH24:MI:SS.FF'))` stmt = fmt.Sprintf(stmt, token, b) fmt.Println(stmt) @@ -53,11 +50,9 @@ func (g *GodrorStore) Commit(token string, b []byte, expiry time.Time) error { } return nil } else if err != nil { - fmt.Println("Other error") return err } - fmt.Println("Update session data") stmt = `UPDATE sessions SET data = '%x', expiry = to_timestamp('` + string(expiry.Format("2006-01-02 15:04:05.00")) + `', 'YYYY-MM-DD HH24:MI:SS.FF') WHERE token = '%x'` stmt = fmt.Sprintf(stmt, b, token) _, err = g.db.Exec(stmt) @@ -69,14 +64,12 @@ func (g *GodrorStore) Commit(token string, b []byte, expiry time.Time) error { } func (g *GodrorStore) Delete(token string) error { - fmt.Println("Delete") stmt := fmt.Sprintf("DELETE FROM session WHERE token = '%x'", token) _, err := g.db.Exec(stmt) return err } func (g *GodrorStore) All() (map[string][]byte, error) { - fmt.Println("All") rows, err := g.db.Query("SELECT token, data FROM sessions WHERE current_timestamp < expiry") if err != nil { return nil, err @@ -108,7 +101,6 @@ func (g *GodrorStore) All() (map[string][]byte, error) { } func (g *GodrorStore) StartCleanup(interval time.Duration) { - fmt.Println("StartCleanup") g.stopCleanup = make(chan bool) ticker := time.NewTicker(interval) for { @@ -126,14 +118,12 @@ func (g *GodrorStore) StartCleanup(interval time.Duration) { } func (g *GodrorStore) StopCleanup() { - fmt.Println("StopCleanup") if g.stopCleanup != nil { g.stopCleanup <- true } } func (g *GodrorStore) deleteExpired() error { - fmt.Println("deleteExpired") _, err := g.db.Exec("DELETE FROM sessions WHERE expiry < current_timestamp") return err } From 54aaf2d923d296133a43a471c3af914c44b9b623 Mon Sep 17 00:00:00 2001 From: Clay Hayes Date: Wed, 15 Nov 2023 10:40:32 -0600 Subject: [PATCH 6/6] Remove last println --- godrorstore/godrorstore.go | 1 - 1 file changed, 1 deletion(-) diff --git a/godrorstore/godrorstore.go b/godrorstore/godrorstore.go index 73d2d1a..a066057 100644 --- a/godrorstore/godrorstore.go +++ b/godrorstore/godrorstore.go @@ -43,7 +43,6 @@ func (g *GodrorStore) Commit(token string, b []byte, expiry time.Time) error { if row.Scan() == sql.ErrNoRows { stmt = `INSERT INTO sessions (token, data, expiry) VALUES ('%x', '%x', to_timestamp('` + string(expiry.Format("2006-01-02 15:04:05.00")) + `', 'YYYY-MM-DD HH24:MI:SS.FF'))` stmt = fmt.Sprintf(stmt, token, b) - fmt.Println(stmt) _, err := g.db.Exec(stmt) if err != nil { return err